Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysdetails): Fixes css issue on sysDetails page #2130

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

adonispuente
Copy link
Collaborator

There was an issue on sysdetails page where when navigating from inventory, and going to vulnerability systems details page, a large gap would appear in between the detail header and the table.

This is a result of double inventory classes. Ive removed the class is this PR as its redundant, and gone in here, removed the class, and seperated the table from the header component.

RedHatInsights/insights-inventory-frontend#2235

Copy link

jira-linking bot commented Aug 21, 2024

Commits missing Jira IDs:
d6119b8

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (985f798) to head (d6119b8).
Report is 1 commits behind head on master.

Files Patch % Lines
...tComponents/SystemDetailsPage/SystemDetailsPage.js 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2130   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         128      128           
  Lines        3440     3440           
  Branches     1067     1067           
=======================================
  Hits         2310     2310           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adonispuente adonispuente merged commit 5f5749e into RedHatInsights:master Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants