Quarantine: - Migration tests that fails due to Migmigration waiting for succeeded #2959
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request modifies a storage migration test file to import the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (12)📓 Common learnings📚 Learning: 2025-06-03T12:36:36.982ZApplied to files:
📚 Learning: 2025-06-18T09:21:34.315ZApplied to files:
📚 Learning: 2025-06-18T09:19:05.769ZApplied to files:
📚 Learning: 2025-10-16T12:47:04.521ZApplied to files:
📚 Learning: 2025-08-13T06:27:29.727ZApplied to files:
📚 Learning: 2025-09-03T07:23:37.045ZApplied to files:
📚 Learning: 2025-05-26T13:36:16.136ZApplied to files:
📚 Learning: 2025-06-22T13:47:35.014ZApplied to files:
📚 Learning: 2025-09-29T19:05:24.987ZApplied to files:
📚 Learning: 2025-08-04T15:27:14.175ZApplied to files:
📚 Learning: 2025-05-27T11:44:14.859ZApplied to files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-3
requested review from
dalia-frank,
duyanyan,
kshvaika and
stesrn
Contributor
Author
|
/verified In local env pytest tests/storage/storage_migration/test_mtc_storage_class_migration.py::TestStorageClassMigrationWindowsWithVTPM::test_vm_storage_class_migration_windows_vm_with_vtpm tests/storage/storage_migration/test_mtc_storage_class_migration.py::TestStorageClassMigrationWithVolumeHotplug::test_vm_storage_class_migration_with_hotplugged_volume Cluster info: CNV 4.21 |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
approved these changes
Dec 1, 2025
Contributor
Test execution plan request detailsCRITICAL: You MUST respond with a review comment on the Files Changed tab, NOT as a regular PR comment. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
|
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 67 🏁 Script executed: Length of output: 1611 @openshift-virtualization-qe-bot-3 I cannot directly post review comments on the Files Changed tab as that requires GitHub UI integration. However, here's the test execution plan content that should be posted as a review comment: Test Execution PlanQuarantine Verification: The following tests should be verified as properly skipped (xfail with
Regression Verification:
Expected Results:
Note: Since this is a quarantine PR with 🧠 Learnings used |
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
jpeimer
requested changes
Dec 2, 2025
Comment on lines
+242
to
+245
| @pytest.mark.xfail( | ||
| reason=f"{QUARANTINED}: Windows MigMigration timeout waiting for condition succeeded. CNV-73329", | ||
| run=False, | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| @pytest.mark.xfail( | |
| reason=f"{QUARANTINED}: Windows MigMigration timeout waiting for condition succeeded. CNV-73329", | |
| run=False, | |
| ) | |
| @pytest.mark.xfail( | |
| reason=f"{QUARANTINED}: MigMigration resource reports Failed for VMs with RWO storage; MIG-1770", | |
| run=False, | |
| ) |
Comment on lines
+171
to
+174
| @pytest.mark.xfail( | ||
| reason=f"{QUARANTINED}: Windows MigMigration timeout waiting for condition succeeded. CNV-73329", | ||
| run=False, | ||
| ) |
Contributor
There was a problem hiding this comment.
- This test is not about Windows
- There's no link to the failure in the CNV-73329 card, there's only a link to the Windows test failure
- Looking at the Win test log - I see that it's MIG-1770 bug. Most likely hotplug test hit the same issue.
13:38:06 2025-11-15T11:37:56.891805 ocp_resources MigMigration INFO Deleting {'apiVersion': 'migration.openshift.io/v1alpha1', 'kind': 'MigMigration', 'metadata': {'annotations': {'openshift.io/touch': '519d1aa5-c216-11f0-b9a0-0a580a810375'}, 'creationTimestamp': '2025-11-15T11:27:54Z', 'generation': 35, 'labels': {'migration.openshift.io/migplan-name': 'storage-mig-plan', 'migration.openshift.io/migration-uid': '8cb0919f-63ed-4758-b5b9-3a79f80d41a7'}, 'managedFields': [{'apiVersion': 'migration.openshift.io/v1alpha1', 'fieldsType': 'FieldsV1', 'fieldsV1': {'f:spec': {'.': {}, 'f:migPlanRef': {}, 'f:migrateState': {}, 'f:quiescePods': {}, 'f:stage': {}}}, 'manager': 'OpenAPI-Generator', 'operation': 'Update', 'time': '2025-11-15T11:27:54Z'}, {'apiVersion': 'migration.openshift.io/v1alpha1', 'fieldsType': 'FieldsV1', 'fieldsV1': {'f:metadata': {'f:annotations': {'.': {}, 'f:openshift.io/touch': {}}, 'f:labels': {'.': {}, 'f:migration.openshift.io/migplan-name': {}, 'f:migration.openshift.io/migration-uid': {}}, 'f:ownerReferences': {'.': {}, 'k:{"uid":"c762adb6-be46-4fff-8a1e-c6cabb5fe963"}': {}}}, 'f:status': {'.': {}, 'f:conditions': {}, 'f:errors': {}, 'f:itinerary': {}, 'f:observedDigest': {}, 'f:phase': {}, 'f:pipeline': {}, 'f:startTimestamp': {}}}, 'manager': 'manager', 'operation': 'Update', 'time': '2025-11-15T11:29:16Z'}], 'name': 'mig-migration-storage', 'namespace': 'openshift-migration', 'ownerReferences': [{'apiVersion': 'migration.openshift.io/v1alpha1', 'kind': 'MigPlan', 'name': 'storage-mig-plan', 'uid': 'c762adb6-be46-4fff-8a1e-c6cabb5fe963'}], 'resourceVersion': '2140175', 'uid': '8cb0919f-63ed-4758-b5b9-3a79f80d41a7'}, 'spec': {'migPlanRef': {'name': 'storage-mig-plan', 'namespace': 'openshift-migration'}, 'migrateState': True, 'quiescePods': True, 'stage': False}, 'status': {'conditions': [{'category': 'Warn', 'durable': True, 'lastTransitionTime': '2025-11-15T11:29:16Z', 'message': 'DirectVolumeMigration (dvm): openshift-migration/mig-migration-storage-x929h failed. See in dvm status.Errors', 'status': 'True', 'type': 'DirectVolumeMigrationFailed'}, {'category': 'Advisory', 'durable': True, 'lastTransitionTime': '2025-11-15T11:29:16Z', 'message': 'The migration has failed. See: Errors.', 'reason': 'WaitForDirectVolumeMigrationToComplete', 'status': 'True', 'type': 'Failed'}], 'errors': ['DVM failed: cannot migrate VMI: PVC windows-11-dv is not shared, live migration requires that all PVCs must be shared (using ReadWriteMany access mode)'], 'itinerary': 'Failed', 'observedDigest': '458005d0e00f41ae25c448db4999139312412b60b9781415cdfb5e88fba3dd04', 'phase': 'Completed', 'pipeline': [{'completed': '2025-11-15T11:28:42Z', 'message': 'Completed', 'name': 'Prepare', 'started': '2025-11-15T11:27:54Z'}, {'completed': '2025-11-15T11:28:42Z', 'message': 'Completed', 'name': 'StageBackup', 'started': '2025-11-15T11:28:42Z'}, {'completed': '2025-11-15T11:29:16Z', 'failed': True, 'message': 'Failed', 'name': 'DirectVolume',
'progress': ['[windows-11-dv] Live Migration storage-migration-test-mtc-storage-class-migration/windows-11-vm-1763205549-6092048:
Failed cannot migrate VMI: PVC windows-11-dv is not shared,
live migration requires that all PVCs must be shared (using ReadWriteMany access mode) (34s)'],
'started': '2025-11-15T11:28:42Z'}, {'completed': '2025-11-15T11:29:16Z', 'message': 'Completed', 'name': 'Cleanup', 'started': '2025-11-15T11:29:16Z'}, {'completed': '2025-11-15T11:29:16Z', 'message': 'Completed', 'name': 'CleanupHelpers', 'started': '2025-11-15T11:29:16Z'}], 'startTimestamp': '2025-11-15T11:27:54Z'}}
Suggested change
| @pytest.mark.xfail( | |
| reason=f"{QUARANTINED}: Windows MigMigration timeout waiting for condition succeeded. CNV-73329", | |
| run=False, | |
| ) | |
| @pytest.mark.xfail( | |
| reason=f"{QUARANTINED}: MigMigration resource reports Failed for VMs with RWO storage; MIG-1770", | |
| run=False, | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Quarantine tests:
test_vm_storage_class_migration_windows_vm_with_vtpm
test_vm_storage_class_migration_with_hotplugged_volume
due to a Timeout waiting for succeeded MigMigration.
jira-ticket:
https://issues.redhat.com/browse/CNV-73329
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.