tests, net, kmp: Add client arg #2980

Anatw · 2025-12-03T13:18:52Z

Short description:

Updated VM fixtures - all calls to openshift-python-wrapper resource should be updated to pass client.

What this PR does / why we need it:

As of its next release, openshift-python-wrapper will enforce passing client when working with cluster resources.
openshift-virtualization-tests must align with this change.
All calls in the code to openshift-python-wrapper resources should be updated to pass client arg.

Since the KMP NS is created with an admin_client the VMs must be created with the same client - VMs under a namespace that is not created by a project admin require admin privileges.

jira-ticket:

https://issues.redhat.com/browse/CNV-72392

Summary by CodeRabbit

Tests
- Fixtures updated to exercise VMs with elevated/admin access to cover additional scenarios.
- VMs are started and waited on during setup so tests hit running state deterministically.
- Added explicit teardown to remove allocated MACs, preventing leftover network state.
- Improves lifecycle validation and overall reliability across network MAC pool configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-03T13:19:16Z

Walkthrough

Added admin_client to three kubemacpool VM fixtures, passed it into VirtualMachineForTests via client=admin_client, started each VM and waited for its VMI to be running, and added teardown cleanup to remove MACs with mac_pool.remove_macs(vm=vm).

Changes

Cohort / File(s)	Change Summary
kubemacpool VM fixtures `tests/network/kubemacpool/conftest.py`	Updated `disabled_ns_vm`, `enabled_ns_vm`, and `no_label_ns_vm` fixtures: replaced `unprivileged_client` with `admin_client`; construct VMs with `client=admin_client`; start VMs and call `vm.vmi.wait_until_running()`; add teardown step calling `mac_pool.remove_macs(vm=vm)` after yield.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Repetitive, consistent edits across three fixtures; low logic density.
Review attention: correct ordering of VM start vs. VMI wait and robustness of mac_pool.remove_macs(vm=vm) for various VM states.

Possibly related PRs

infra/tests, net, udn: mandatory client for CUDN #2948 — also adds admin_client and threads it into VM/resource constructors.
add mandatory client parameter to fedora_vm #2387 — adds and propagates a Kubernetes DynamicClient (admin_client) into VM fixture creation.
tests, net, network_policy: Add client arg #2826 — applies the same pattern of adding a client parameter and passing it into VirtualMachineForTests.

Suggested reviewers

EdDev
yossisegev
servolkov
azhivovk
rnetser

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding client arguments to kubemacpool test fixtures.
Description check	✅ Passed	The description includes required sections with clear rationale for the change and explains the need for admin_client in the KMP namespace context.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ff142d and fd67fcc.

📒 Files selected for processing (1)

tests/network/kubemacpool/conftest.py (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/network/kubemacpool/conftest.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-virtualization-qe-bot · 2025-12-03T13:19:23Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Pre-commit Checks: pre-commit runs automatically if .pre-commit-config.yaml exists
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No WIP, hold, or conflict labels
Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

EdDev

Reviewers:

Anatw
EdDev
azhivovk
servolkov
yossisegev

Available Labels

hold
verified
wip
lgtm
approve
automerge

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is automatically removed on each new commit
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

azhivovk

VMs require admin_client? Maybe we can use unprivileged_client?

Anatw · 2025-12-03T15:27:35Z

#2980 (review)
@azhivovk We can't since the KMP NS is created with an admin_client
https://vscode.dev/github/RedHatQE/openshift-virtualization-tests/blob/main/utilities/infra.py#L99-L100

Anatw · 2025-12-03T15:29:09Z

/build-and-push-container

openshift-virtualization-qe-bot-2 · 2025-12-03T15:31:06Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-2980 published

Anatw · 2025-12-03T16:36:19Z

/verified

Tested locally (quota issue in Jenkins) on bm02-ibm
Cluster version is 4.21.0-ec.3
kubevirt-hyperconverged-operator.v4.21.0
iib: 1072960
PYTEST_PARAMS: -s --rhel-os-matrix=rhel-8-10 --windows-os-matrix=win-2022 --centos-os-matrix=centos-stream-9 --fedora-os-matrix=fedora-41 --pdbcls=IPython.terminal.debugger:TerminalPdb --tc-format=python --storage-class-matrix=ocs-storagecluster-ceph-rbd-virtualization --skip-deprecated-api-test -m tier2 --tc=vlans:861,978,1138 tests/network/kubemacpool/

Test Result:
======= 10 passed, 1 deselected, 44 warnings in 926.71s (0:15:26) =====

openshift-virtualization-qe-bot-3 · 2025-12-03T16:36:45Z

@coderabbitai

Test execution plan request details

CRITICAL: You MUST respond with a review comment on the Files Changed tab, NOT as a regular PR comment.
If it cannot be on the 1st line of the 1st file, add it to any other changed file.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will create a change request comment on the 1st line of the 1st file in the pr with the test execution plan.
If you fail to run or post a comment, retry.

Analysis Requirements:

Examine code changes in each modified file
Identify affected code paths, functions, and classes
Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
Trace test dependencies through imports, shared utilities, and fixture inheritance
Detect new tests introduced in the PR

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

path/to/test_file.py - When the entire test file needs verification
path/to/test_file.py::TestClass::test_method - When specific test(s) needed
path/to/test_file.py::test_function - When specific test(s) needed
-m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

Include only tests directly affected by the changes
Use a full file path only if ALL tests in that file require verification
Use file path + test name if only specific tests are needed
If a test marker can cover multiple files/tests, provide the marker
Balance coverage vs over-testing - Keep descriptions minimal
Do not add a follow-up comment in the PR, only the change request one

coderabbitai · 2025-12-03T16:37:58Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find all test files in the kubemacpool directory
echo "=== Test files in tests/network/kubemacpool/ ==="
fd -e py -t f . tests/network/kubemacpool/

echo -e "\n=== Searching for usage of disabled_ns_vm fixture ==="
rg -n --type=py 'disabled_ns_vm' tests/network/kubemacpool/

echo -e "\n=== Searching for usage of enabled_ns_vm fixture ==="
rg -n --type=py 'enabled_ns_vm' tests/network/kubemacpool/

echo -e "\n=== Searching for usage of no_label_ns_vm fixture ==="
rg -n --type=py 'no_label_ns_vm' tests/network/kubemacpool/

Length of output: 1406

🏁 Script executed:

#!/bin/bash
# Get the test names that use these fixtures
echo "=== Examining test_kubemacpool.py for test names ==="
rg -n -B 5 -A 2 'def test_.*\(' tests/network/kubemacpool/test_kubemacpool.py | head -100

echo -e "\n=== Full context around fixture usage ==="
rg -n -B 10 'disabled_ns_vm|enabled_ns_vm|no_label_ns_vm' tests/network/kubemacpool/test_kubemacpool.py | grep -E '(def test_|disabled_ns_vm|enabled_ns_vm|no_label_ns_vm)'

Length of output: 4309

@openshift-virtualization-qe-bot-3

Test Execution Plan

Based on the analysis of the modified fixtures in tests/network/kubemacpool/conftest.py, the following tests should be executed:

Directly Affected Tests

These tests use the modified fixtures (disabled_ns_vm, enabled_ns_vm, no_label_ns_vm):

tests/network/kubemacpool/test_kubemacpool.py::TestKubemacpool::test_enabled_label_ns - Uses enabled_ns_vm fixture
tests/network/kubemacpool/test_kubemacpool.py::TestKubemacpool::test_no_label_ns - Uses no_label_ns_vm fixture
tests/network/kubemacpool/test_kubemacpool.py::TestNegatives::test_disabled_assignment_ns - Uses disabled_ns_vm fixture

Comprehensive Validation (Recommended)

tests/network/kubemacpool/ - Full directory test to ensure no regression from conftest changes

Note: The PR author has already validated the entire kubemacpool test suite locally with successful results (10 passed, 1 deselected).

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.

Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 2045
File: tests/virt/cluster/vm_lifecycle/conftest.py:46-47
Timestamp: 2025-09-15T06:49:53.478Z
Learning: In the openshift-virtualization-tests repo, large fixture refactoring efforts like the golden image data source migration are handled incrementally by directory/team ownership. The virt/cluster directory is handled separately from virt/node, tests/infra, tests/storage, etc., with each area managed by relevant teams in follow-up PRs.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds the OS_FLAVOR attribute to the Images.Cirros class, making Images.Cirros.OS_FLAVOR available for conditional logic in tests.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR #1904 focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: For PR #1904 test execution, the critical validation point is test_connectivity_over_migration_between_localnet_vms which should fail gracefully on cloud clusters but pass on bare-metal/PSI clusters, representing the core nmstate conditional logic functionality.

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.

Learnt from: SiboWang1997
Repo: RedHatQE/openshift-virtualization-tests PR: 1566
File: tests/global_config_x86_64.py:29-29
Timestamp: 2025-07-25T01:59:02.180Z
Learning: In the openshift-virtualization-tests repo, the s390x architecture still relies on Fedora 41 images, while only x86_64 is updated to Fedora 42 in PR #1566.

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/conftest.py:289-297
Timestamp: 2025-08-09T01:52:26.683Z
Learning: When user dshchedr moves working code from one location to another in the openshift-virtualization-tests repository, they prefer not to modify it unless there's a real issue, maintaining the original implementation to avoid introducing unnecessary changes.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2701
File: .github/scripts/coderabbit_workflow.py:45-46
Timestamp: 2025-11-27T11:45:54.224Z
Learning: In the openshift-virtualization-tests repository, when using the PyGithub library or similar API clients, rnetser prefers to rely on API-level validation rather than adding redundant client-side input validation, since the API will handle validation and raise appropriate errors.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1028
File: utilities/infra.py:1249-1254
Timestamp: 2025-08-06T13:57:51.928Z
Learning: User rnetser verified that all calls to get_infrastructure() function use the admin_client parameter, confirming that signature changes requiring this parameter don't cause breaking changes in the openshift-virtualization-tests codebase.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1028
File: utilities/infra.py:1257-1258
Timestamp: 2025-08-06T13:57:34.740Z
Learning: In the openshift-virtualization-tests repository, all existing calls to the `get_cluster_platform` function in utilities/infra.py already pass the `admin_client` parameter, so the breaking change requiring this parameter does not actually break any existing code.

Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 1678
File: utilities/oadp.py:1-5
Timestamp: 2025-09-07T13:16:32.011Z
Learning: In the openshift-virtualization-tests project utilities/oadp.py, DynamicClient instances are passed as parameters rather than created internally, so kubernetes.config import is not needed for client creation fallback patterns.

Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 1678
File: utilities/oadp.py:5-5
Timestamp: 2025-08-28T11:29:15.768Z
Learning: In the openshift-virtualization-tests project, DynamicClient is imported from kubernetes.dynamic, not openshift.dynamic. The standard import pattern is `from kubernetes.dynamic import DynamicClient`.

Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 1678
File: utilities/oadp.py:5-5
Timestamp: 2025-08-28T11:29:15.768Z
Learning: In the openshift-virtualization-tests project, DynamicClient is imported from kubernetes.dynamic, not openshift.dynamic. The standard import pattern is `from kubernetes.dynamic import DynamicClient`.

As of its next release, openshift-python-wrapper will enforce passing client when working with cluster resources. openshift-virtualization-tests must align with this change. All calls in the code to openshift-python-wrapper resources should be updated to pass client arg. Since the KMP NS is created with an admin_client the VMs must be created with the same client - VMs under a namespace that is not created by a project admin require admin privileges. Signed-off-by: Anat Wax <[email protected]>

Anatw · 2025-12-08T08:10:02Z

Change: rebase on main, resolve conflicts in tests/network/kubemacpool/conftest.py.

Anatw · 2025-12-08T08:11:24Z

/build-and-push-container

openshift-virtualization-qe-bot-3 · 2025-12-08T08:16:36Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-2980 published

Anatw · 2025-12-08T08:48:22Z

/verified

Tested on bm02-ibm
Cluster version is 4.21.0-ec.3
kubevirt-hyperconverged-operator.v4.21.0
iib: 1072960

Tested locally due to an issue in Jenkins.
PYTEST_PARAMS: uv run pytest -s --rhel-os-matrix=rhel-8-10 --windows-os-matrix=win-2022 --centos-os-matrix=centos-stream-9 --fedora-os-matrix=fedora-41 --pdbcls=IPython.terminal.debugger:TerminalPdb --tc-format=python --storage-class-matrix=ocs-storagecluster-ceph-rbd-virtualization --skip-deprecated-api-test --tc=vlans:861,978,1138 tests/network/kubemacpool/test_kubemacpool.py
Results: ====== 10 passed, 1 deselected, 44 warnings in 970.26s (0:16:10) ======

openshift-virtualization-qe-bot-3 · 2025-12-08T08:48:48Z

@coderabbitai

Test execution plan request details

CRITICAL: You MUST respond with a review comment on the Files Changed tab, NOT as a regular PR comment.
If it cannot be on the 1st line of the 1st file, add it to any other changed file.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will create a change request comment on the 1st line of the 1st file in the pr with the test execution plan.
If you fail to run or post a comment, retry.

Analysis Requirements:

Examine code changes in each modified file
Identify affected code paths, functions, and classes
Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
Trace test dependencies through imports, shared utilities, and fixture inheritance
Detect new tests introduced in the PR

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

path/to/test_file.py - When the entire test file needs verification
path/to/test_file.py::TestClass::test_method - When specific test(s) needed
path/to/test_file.py::test_function - When specific test(s) needed
-m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

Include only tests directly affected by the changes
Use a full file path only if ALL tests in that file require verification
Use file path + test name if only specific tests are needed
If a test marker can cover multiple files/tests, provide the marker
Balance coverage vs over-testing - Keep descriptions minimal
Do not add a follow-up comment in the PR, only the change request one

coderabbitai · 2025-12-08T08:49:59Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Get the modified conftest.py file to see current state after rebase
echo "=== Contents of tests/network/kubemacpool/conftest.py ==="
cat tests/network/kubemacpool/conftest.py

echo -e "\n\n=== Finding all tests that use the modified fixtures ==="
rg -n --type=py -C3 'disabled_ns_vm|enabled_ns_vm|no_label_ns_vm' tests/network/kubemacpool/test_kubemacpool.py | grep -E '(def test_|disabled_ns_vm|enabled_ns_vm|no_label_ns_vm)'

echo -e "\n\n=== List all test files in kubemacpool directory ==="
fd -e py -t f . tests/network/kubemacpool/

Length of output: 10839

🏁 Script executed:

#!/bin/bash

# Get the full test file to identify exact test names
echo "=== Full test_kubemacpool.py content ==="
cat tests/network/kubemacpool/test_kubemacpool.py | grep -B 10 'enabled_ns_vm\|no_label_ns_vm\|disabled_ns_vm' | grep -E '(class Test|def test_)'

Length of output: 155

@openshift-virtualization-qe-bot-3

I've analyzed the latest changes in this PR after the rebase on main. The modifications remain functionally the same - the three fixtures now use admin_client instead of unprivileged_client with proper client parameter passing.

Test Execution Plan

Directly Affected Tests

The following tests use the modified fixtures and should be executed:

tests/network/kubemacpool/test_kubemacpool.py::TestKubemacpool::test_enabled_label_ns - Uses enabled_ns_vm fixture
tests/network/kubemacpool/test_kubemacpool.py::TestKubemacpool::test_no_label_ns - Uses no_label_ns_vm fixture
tests/network/kubemacpool/test_kubemacpool.py::TestNegatives::test_disabled_assignment_ns - Uses disabled_ns_vm fixture

Comprehensive Validation (Recommended)

tests/network/kubemacpool/test_kubemacpool.py - Full test file to ensure complete validation after rebase

Verification Status: The PR author (@Anatw) has successfully validated these changes after the rebase on bm02-ibm cluster (4.21.0-ec.3) with all 10 tests passing and 1 deselected.

🧠 Learnings used

Learnt from: SamAlber
Repo: RedHatQE/openshift-virtualization-tests PR: 2507
File: tests/virt/node/general/test_vmi_reset.py:26-29
Timestamp: 2025-11-19T08:13:30.263Z
Learning: In the openshift-virtualization-tests repository, user SamAlber prefers not to define fixture dependencies by chaining fixtures (adding one fixture as a parameter to another). Instead, all fixture dependencies should be explicitly declared as parameters in the test method itself, relying on parameter order to control execution sequence.

Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 2119
File: tests/network/localnet/conftest.py:372-387
Timestamp: 2025-11-26T16:03:07.813Z
Learning: In the openshift-virtualization-tests repository, pytest fixtures that declare other fixtures as parameters purely for dependency ordering (without referencing them in the function body) should not be modified to silence Ruff ARG001 warnings. This is an idiomatic pytest pattern for ensuring setup order, and the team prefers to leave such fixtures unchanged rather than adding defensive comments or code to suppress linter warnings.

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/node/workload_density/test_swap.py:71-85
Timestamp: 2025-08-09T01:46:48.039Z
Learning: In the openshift-virtualization-tests repository, user dshchedr prefers that all test setup fixtures be explicitly declared as parameters in the test method itself rather than chaining fixtures through dependencies. This makes all setup steps visible in one place at the test method level, improving test readability and making dependencies explicit, even if a fixture isn't directly used within another fixture's implementation.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 2045
File: tests/virt/cluster/vm_lifecycle/conftest.py:46-47
Timestamp: 2025-09-15T06:49:53.478Z
Learning: In the openshift-virtualization-tests repo, large fixture refactoring efforts like the golden image data source migration are handled incrementally by directory/team ownership. The virt/cluster directory is handled separately from virt/node, tests/infra, tests/storage, etc., with each area managed by relevant teams in follow-up PRs.

Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 1166
File: tests/observability/metrics/test_vms_metrics.py:129-137
Timestamp: 2025-06-18T09:19:05.769Z
Learning: For Windows VM testing in tests/observability/metrics/test_vms_metrics.py, it's acceptable to have more fixture parameters than typical pylint recommendations when reusing expensive Windows VM fixtures for performance. Windows VMs take a long time to deploy, so reusing fixtures like windows_vm_for_test and adding labels via windows_vm_with_low_bandwidth_migration_policy is preferred over creating separate fixtures that would require additional VM deployments.

Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 1166
File: tests/observability/metrics/conftest.py:1065-1077
Timestamp: 2025-06-18T09:21:34.315Z
Learning: In tests/observability/metrics/conftest.py, when creating fixtures that modify shared Windows VM state (like changing nodeSelector), prefer using function scope rather than class scope to ensure ResourceEditor context managers properly restore the VM state after each test, maintaining test isolation while still reusing expensive Windows VM fixtures.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1932
File: tests/virt/node/migration_and_maintenance/conftest.py:57-64
Timestamp: 2025-09-08T21:34:28.924Z
Learning: In OpenShift Virtualization tests, MigrationPolicy fixtures should use static names rather than unique suffixes to enable collision detection. If parallel test runs collide on cluster-scoped resource names like MigrationPolicy, it's better to know about the collision rather than hide it with unique naming, as confirmed by maintainer dshchedr.

Learnt from: josemacassan
Repo: RedHatQE/openshift-virtualization-tests PR: 2300
File: tests/storage/online_resize/conftest.py:94-96
Timestamp: 2025-10-30T10:43:48.886Z
Learning: In tests/storage/online_resize/conftest.py, the `running_rhel_vm` fixture is intentionally designed to only invoke `running_vm(vm=rhel_vm_for_online_resize)` without returning or yielding a value. It's used as a dependency fixture to ensure the VM is running before other fixtures/tests execute, while the actual VM object is accessed via the `rhel_vm_for_online_resize` fixture.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: For PR #1904 test execution, the critical validation point is test_connectivity_over_migration_between_localnet_vms which should fail gracefully on cloud clusters but pass on bare-metal/PSI clusters, representing the core nmstate conditional logic functionality.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1028
File: utilities/infra.py:1249-1254
Timestamp: 2025-08-06T13:57:51.928Z
Learning: User rnetser verified that all calls to get_infrastructure() function use the admin_client parameter, confirming that signature changes requiring this parameter don't cause breaking changes in the openshift-virtualization-tests codebase.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR #1904 focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1028
File: utilities/infra.py:1257-1258
Timestamp: 2025-08-06T13:57:34.740Z
Learning: In the openshift-virtualization-tests repository, all existing calls to the `get_cluster_platform` function in utilities/infra.py already pass the `admin_client` parameter, so the breaking change requiring this parameter does not actually break any existing code.

Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 2119
File: tests/network/localnet/conftest.py:352-366
Timestamp: 2025-10-31T13:05:24.570Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, tests run sequentially by default on the same cluster (with module-scoped fixtures properly cleaned up between modules), and parallel test runs use different machines/clusters. This means cluster-scoped resources (like ClusterUserDefinedNetwork or NodeNetworkConfigurationPolicy) can safely use the same names across different test modules without risk of collision.

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-07T14:51:53.484Z
Learning: In the openshift-virtualization-tests repository, the team has decided to avoid using predefined time constants (like TIMEOUT_2MIN, TIMEOUT_5SEC) and prefers using explicit numeric values for timeout parameters.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/conftest.py:289-297
Timestamp: 2025-08-09T01:52:26.683Z
Learning: When user dshchedr moves working code from one location to another in the openshift-virtualization-tests repository, they prefer not to modify it unless there's a real issue, maintaining the original implementation to avoid introducing unnecessary changes.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2701
File: .github/scripts/coderabbit_workflow.py:45-46
Timestamp: 2025-11-27T11:45:54.224Z
Learning: In the openshift-virtualization-tests repository, when using the PyGithub library or similar API clients, rnetser prefers to rely on API-level validation rather than adding redundant client-side input validation, since the API will handle validation and raise appropriate errors.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds the OS_FLAVOR attribute to the Images.Cirros class, making Images.Cirros.OS_FLAVOR available for conditional logic in tests.

Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 1678
File: utilities/oadp.py:1-5
Timestamp: 2025-09-07T13:16:32.011Z
Learning: In the openshift-virtualization-tests project utilities/oadp.py, DynamicClient instances are passed as parameters rather than created internally, so kubernetes.config import is not needed for client creation fallback patterns.

RoniKishner · 2025-12-08T08:53:46Z

/lgtm

EdDev

/approve

openshift-virtualization-qe-bot-3 · 2025-12-08T15:14:50Z

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-2980.

openshift-virtualization-qe-bot-3 · 2025-12-08T15:20:06Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

github-actions bot added the sig-network label Dec 3, 2025

openshift-virtualization-qe-bot requested a review from yossisegev December 3, 2025 13:19

openshift-virtualization-qe-bot assigned Anatw Dec 3, 2025

openshift-virtualization-qe-bot mentioned this pull request Dec 3, 2025

tests, net, kmp: Add client arg - 2980 #2981

Closed

openshift-virtualization-qe-bot requested a review from servolkov December 3, 2025 13:19

openshift-virtualization-qe-bot added branch-main size/XS labels Dec 3, 2025

openshift-virtualization-qe-bot requested review from EdDev and azhivovk December 3, 2025 13:19

openshift-virtualization-qe-bot added tox:verify-bugs-are-open:running D/S Testing tox:verify-bugs-are-open:passed D/S Testing and removed tox:verify-bugs-are-open:running D/S Testing labels Dec 3, 2025

openshift-virtualization-qe-bot previously approved these changes Dec 3, 2025

View reviewed changes

openshift-virtualization-qe-bot-2 added the lgtm-openshift-virtualization-qe-bot label Dec 3, 2025

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Dec 3, 2025

azhivovk reviewed Dec 3, 2025

View reviewed changes

openshift-virtualization-qe-bot added the commented-azhivovk label Dec 3, 2025

openshift-virtualization-qe-bot-2 added the verified label Dec 3, 2025

azhivovk approved these changes Dec 3, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-azhivovk label Dec 3, 2025

openshift-virtualization-qe-bot added lgtm-EdDev approved-EdDev has-conflicts labels Dec 8, 2025

Anatw dismissed openshift-virtualization-qe-bot’s stale review via fd67fcc December 8, 2025 08:09

Anatw force-pushed the add_client_kmp_bm branch from 0fe60ef to fd67fcc Compare December 8, 2025 08:09

openshift-virtualization-qe-bot removed verified lgtm-EdDev lgtm-openshift-virtualization-qe-bot approved-EdDev has-conflicts labels Dec 8, 2025

openshift-virtualization-qe-bot requested a review from EdDev December 8, 2025 08:10

openshift-virtualization-qe-bot-3 added the verified label Dec 8, 2025

openshift-virtualization-qe-bot added the lgtm-RoniKishner label Dec 8, 2025

azhivovk approved these changes Dec 8, 2025

View reviewed changes

openshift-virtualization-qe-bot-3 added the lgtm-azhivovk label Dec 8, 2025

EdDev reviewed Dec 8, 2025

View reviewed changes

openshift-virtualization-qe-bot added commented-EdDev approved-EdDev labels Dec 8, 2025

openshift-virtualization-qe-bot-3 added the can-be-merged label Dec 8, 2025

rnetser merged commit 0267c66 into RedHatQE:main Dec 8, 2025
15 checks passed

tests, net, kmp: Add client arg #2980

tests, net, kmp: Add client arg #2980

Conversation

Anatw commented Dec 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

What this PR does / why we need it:

jira-ticket:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

openshift-virtualization-qe-bot commented Dec 3, 2025

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

azhivovk left a comment

Choose a reason for hiding this comment

Uh oh!

Anatw commented Dec 3, 2025

Uh oh!

Anatw commented Dec 3, 2025

Uh oh!

openshift-virtualization-qe-bot-2 commented Dec 3, 2025

Uh oh!

Anatw commented Dec 3, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Dec 3, 2025

Uh oh!

coderabbitai bot commented Dec 3, 2025

Test Execution Plan

Directly Affected Tests

Comprehensive Validation (Recommended)

Uh oh!

Anatw commented Dec 8, 2025

Uh oh!

Anatw commented Dec 8, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Dec 8, 2025

Uh oh!

Anatw commented Dec 8, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Dec 8, 2025

Uh oh!

coderabbitai bot commented Dec 8, 2025

Test Execution Plan

Directly Affected Tests

Comprehensive Validation (Recommended)

Uh oh!

RoniKishner commented Dec 8, 2025

Uh oh!

EdDev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-3 commented Dec 8, 2025

Uh oh!

openshift-virtualization-qe-bot-3 commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Anatw commented Dec 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 3, 2025 •

edited

Loading