Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning #138

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Cleaning #138

merged 10 commits into from
Jul 17, 2024

Conversation

osipxd
Copy link
Collaborator

@osipxd osipxd commented Jul 10, 2024

⚠️ BREAKING CHANGES

  • common: Deprecate redmadrobot.jvmTarget with deprecation level Error.
    Use JVM Toolchains instead to specify JVM target.
    Kotlin, Android Gradle Plugin, detekt and many other tools have support for this mechanism,
    In most cases, adding this into your build.gradle.kts should be enough:

    kotlin {
        jvmToolchain(17)
    }

    You can also configure automatic toolchains downloading.

  • common: Disable automatic repositories adding by default.
    If you rely on this feature, consider declaring required repositories explicitly, or enable it in gradle.properties:

    redmadrobot.add.repositories=true
  • android: Do not add LOCK_ORIENTATION and CRASH_REPORTS_ENABLED variables to BuildConfig implicitly

Other Changes

  • android: Use ANDROID_BUILD_TOOLS_VERSION env variable for buildToolsVersion if the option is not configured (closes android: Use buildToolsVersion from ANDROID_BUILD_TOOLS_VERSION env variable #132)
  • android: Add the option redmadrobot.android.ndkVersion to specify NDK version for all android modules
  • android: Remove disabling of build features aidl, renderScript and buildConfig as they are already disabled by default in new versions of AGP

@osipxd osipxd self-assigned this Jul 10, 2024
@osipxd osipxd added this to the Next milestone Jul 10, 2024
@osipxd osipxd force-pushed the feature/cleaning branch from 719bf9f to c5c9107 Compare July 10, 2024 12:25
@osipxd osipxd marked this pull request as ready for review July 10, 2024 12:57
@AleksandrTabolin
Copy link

@osipxd апрув)

@osipxd osipxd merged commit eed0909 into develop Jul 17, 2024
4 checks passed
@osipxd osipxd deleted the feature/cleaning branch July 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android: Use buildToolsVersion from ANDROID_BUILD_TOOLS_VERSION env variable
2 participants