Simple fix for use of Item5e.createOwned #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate you have stopped development on Better Rolls. However I have created the PR incase some one picks up this work |
|
The project has been picked up, but its getting quite the update, and apparently this has been fixed as part of it. Just to let you know. |
|
@CarlosFdez Are there any infos on the progress or is it done as a separate fork? |
|
When can we get eyes on the update please. Would be very happy to test |
|
I am not sure. I think they're waiting for Foundry V10 maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of Item5e.createOwned as this has been dropped from the product.
This was causing issues when BetterRolls5e was interacting with spells that were fired from Magic Items