fix: section type Link does not render in "CartellaModulistica" #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamico
reviewed
Aug 17, 2023
src/components/ItaliaTheme/View/CartellaModulisticaView/CartellaModulisticaView.jsx
Outdated
Show resolved
Hide resolved
mamico
reviewed
Aug 17, 2023
src/components/ItaliaTheme/View/CartellaModulisticaView/CartellaModulisticaView.jsx
Outdated
Show resolved
Hide resolved
mamico
approved these changes
Aug 17, 2023
mamico
changed the title
| key={section['@id']} | ||
| items={section.items.filter(filterItemsFN)} | ||
| /> | ||
| <DocRow doc={section} /> |
There was a problem hiding this comment.
perchè hai tolto la prop 'items'?
togliendola non si vedono i moduli figli di un contenuto di tipo Documento
There was a problem hiding this comment.
document va nel ramo sopra dell'if, non lì
section['@type'] === 'Document' ? ...
eventualmente ora gli oggetti non document che hanno subitems non mostranno i subitem ma solo l'oggetto, ma è un caso che non era gestito neanche prima, e mi sembra di capire neanche previsto.
There was a problem hiding this comment.
no.. vanno mostrati, gli oggetti non Document che hanno subitem possono essere oggetti di tipo Documento di cui si devono poter vedere i moduli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
section type Link does not render