[MOD-11910]Fix thread count report in SVS Tiered index debug info & [MOD-11913] Increase threads' reservation timeout

[meiravgri]

MOD-11910 Fix SVS Tiered index debug info thread count

Background

When SVS adds vectors in a multi-threaded environment:

1. The system first attempts to reserve threads from the thread pool
2. After reservation timeout, updateSVSIndex is called with the number of successfully reserved threads (which may be fewer than the total pool capacity)
3. The thread count is temporarily adjusted via setNumThreads() for the addVectors operation
4. The threapool size is not restored to the original pool capacity after the operation

Current Behavior

debugInfo() reports the thread count via getNumThreads(), which might have been modified by the last addVectors operation, instead of the actual thread pool capacity.

The Fix

1. Fixed numThreads field: Now populated via getThreadPoolCapacity(), which reflects the configured capacity and not the temporarily modified value
2. Added lastReservedThreads field: New field that reports the number of threads that were successfully reserved by the last ingestion operation, populated via getNumThreads()

MOD-11913 Increase threads' reservation timeout

Increased SVS_DEFAULT_UPDATE_JOB_WAIT_TIME: Changed from 0.1 ms to 5 ms to improve thread reservation reliability in multi-threaded scenarios

[Additional] Thread Management API Contract Enforcement For addVector/addVectors API

Background

The original SVS implementation had inconsistent thread management behavior:

• Single vector operations (addVector) would temporarily set thread count to 1, then restore to the previous value
• This restoration logic created inconsistencies when called through different code paths (tiered index writeInPlace mode when threadpool capacity >1 vs. async mode)

The Changes

1. Removed automatic thread adjustment in addVectorsImpl: Eliminated the logic that automatically set thread count to 1 for single vector operations and then restored it
2. Added API contract enforcement via assertions:
   • addVector(): Now requires numThreads == 1, enforced by assertion
   • addVectors(): Prohibits calling with n=1 when numThreads > 1, enforced by assertion
3. Updated tiered index to respect the contract:
   • Write-in-place mode: Explicitly sets numThreads = 1 before calling addVector()
   • Async mode: Already properly manages thread count via existing setNumThreads() calls
4. Updated test infrastructure: Modified CreateTieredSVSIndex to default numThreads = 1, allowing tests to call SVS methods directly while maintaining the single-thread contract

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (00bf35d) to head (275da79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files         126      126           
  Lines        7739     7740    +1     
=======================================
+ Hits         7496     7497    +1     
  Misses        243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Successfully created backport PR for 8.2:

• [8.2] [MOD-11910]Fix thread count report in SVS Tiered index debug info & [MOD-11913] Increase threads' reservation timeout #809