[SVS] Add test with direct call to SVS distance computations #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiravgri
added a commit
that referenced
this pull request
Dec 10, 2025
* Use system page protection to catch the unmasked vector loading issue * Do not use pre-compiled SVS binaries but compile from sources * Update SVS submodule to the latest main with AVX2 fixes
rfsaliev
commented
Dec 11, 2025
| GLIBC_2_26_FOUND) | ||
| endif() | ||
|
|
||
| cmake_dependent_option(SVS_SHARED_LIB "Use SVS pre-compiled shared library" ON "USE_SVS AND GLIBC_FOUND AND SVS_LVQ_SUPPORTED" OFF) |
Collaborator
Author
There was a problem hiding this comment.
TODO: revert this change upon SVS binaries update
rfsaliev
force-pushed
the
rfsaliev/test-svs-distance
branch
from
79b8abd to
5128cf4
Compare
rfsaliev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds SVS distance computation tests to catch memory access error caused by unmasked vector loading instructions
A clear and concise description of what the PR is solving.
Which issues this PR fixes
Main objects this PR modified
Mark if applicable