Added support for showExtensions and $ref for Responses #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
requested changes
Oct 13, 2020
Member
RomanHotsiy
left a comment
RomanHotsiy
left a comment
There was a problem hiding this comment.
It looks good, the only question is if the test message is corret?
| expect(resp.type).toEqual('error'); | ||
| }); | ||
|
|
||
| test('should be error if showExtensions is true', () => { |
Contributor
Author
There was a problem hiding this comment.
Oops! I missed updating the first half. ;)
gileswells
reviewed
Oct 13, 2020
Member
|
Thanks for your contribution. I will merge it after the release today so it will land into the next release. |
RomanHotsiy
approved these changes
Oct 13, 2020
Contributor
Author
|
Thanks much, including for the tagging |
Contributor
Author
|
@RomanHotsiy - Please merge this when you get a chance to unblock #1434 and #1435 |
andriyl
force-pushed
the
master
branch
2 times, most recently
from
cc0c845 to
3c4ece9
Compare
Oprysk
force-pushed
the
master
branch
4 times, most recently
from
4ea3dd1 to
b4f3f02
Compare
Member
|
Hey @shelbys! I am very sorry for the 1-year delay! 🙈 We now have more resources and time to work on Redoc so this PR will be merged today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you appreciate this contribution, please add a
hacktoberfest-acceptedLabel to the PR, so it'll be tracked