Skip to content

[DO NOT MERGE] Add wake_all_threads_time metric #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: v1.10.2+RAI
Choose a base branch
from
Draft

[DO NOT MERGE] Add wake_all_threads_time metric #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/partr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,13 @@ static void wake_libuv(void) JL_NOTSAFEPOINT
JULIA_DEBUG_SLEEPWAKE( io_wakeup_leave = cycleclock() );
}

_Atomic(uint64_t) wake_all_threads_time = 0;

JL_DLLEXPORT uint64_t jl_get_wake_all_threads_time(void)
{
return jl_atomic_load_relaxed(&wake_all_threads_time);
}

/* ensure thread tid is awake if necessary */
JL_DLLEXPORT void jl_wakeup_thread(int16_t tid) JL_NOTSAFEPOINT
{
Expand Down Expand Up @@ -317,12 +324,15 @@ JL_DLLEXPORT void jl_wakeup_thread(int16_t tid) JL_NOTSAFEPOINT
// something added to the multi-queue: notify all threads
// in the future, we might want to instead wake some fraction of threads,
// and let each of those wake additional threads if they find work
uint64_t tw = jl_hrtime();
int anysleep = 0;
int nthreads = jl_atomic_load_acquire(&jl_n_threads);
for (tid = 0; tid < nthreads; tid++) {
if (tid != self)
anysleep |= wake_thread(tid);
}
tw = jl_hrtime() - tw;
jl_atomic_fetch_add_relaxed(&wake_all_threads_time, tw);
// check if we need to notify uv_run too
if (uvlock != ct && anysleep) {
jl_fence();
Expand Down