[WIP] Add Chromecast Support #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmakenoise
commented
Oct 11, 2018
| @@ -321,8 +321,20 @@ | |||
|
|
|||
| play() { | |||
| this.debug('play'); | |||
|
|
|||
| if (chrome.cast && window.cast) { | |||
There was a problem hiding this comment.
This stuff will all be cleared out in the end, ignore for now.
|
@danmakenoise anything to push up? I can wrap this up. |
|
@switz this is where I left it, happy to go over it with you and hand it off. Sorry for not having the time to see it through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chromecast Support (Work in Progress)
This PR is in reference to #40.
Todo
How to Test Current Implementation
The current implementation is still very basic, and buggy, but for now here is what you can do:
Troubleshooting
If the button doesn't show up check the following: