Increase touch targets to 44px minimum (#221) - #253
Merged
arisu6804 merged 2 commits intoJul 21, 2026
Conversation
- Add min-height/min-width: 44px to all interactive elements - Increase swap button from 40x40 to 44x44 - Add display: inline-flex with centering to modal close button - Increase navbar/footer link padding for larger hit areas - Add touch-target compliance test suite (19 tests) - Update README with accessibility documentation
Contributor
|
LGTM — clean and focused, thanks! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring all interactive elements into compliance with WCAG 2.5.5 (Target Size) by ensuring every tappable/clickable element has a minimum touch target of 44×44 CSS pixels.
Changes
CSS (19 files)
Button.cssmin-height: 44pxCopyButton.cssmin-height: 44pxPagination.cssmin-height: 44pxErrorMessage.cssmin-height: 44pxErrorBoundary.cssmin-height: 44pxDataTable.cssmin-height: 44pxModal.cssmin-width/min-height: 44px+ flex centeringSidebar.cssmin-height: 44pxSidebar.cssmin-height: 44pxNavbar.cssdisplay: inline-block, increased padding,min-height: 44pxFooter.cssdisplay: inline-block, added padding,min-height: 44pxApp.cssmin-height: 44pxSendMoney.cssSelectionToolbar.cssmin-height: 44pxon label; checkbox → 1.125remSelectionToolbar.cssmin-height: 44pxTextField.cssmin-height: 44pxCurrencySelect.cssmin-height: 44pxLocaleSelect.cssmin-height: 44pxPullToRefresh.cssmin-height: 44pxTesting
test/touch-targets.test.js— 19 automated tests that audit each component's CSS for the requiredmin-height/min-widthdeclarations. Follows the same static-analysis pattern ascontrast.test.js.Documentation
README.md— Added an Accessibility section documenting the WCAG 2.5.5 compliance and the associated test suite.Verification
npm run buildcompletes successfullyCloses #221