Feature/bills create input validation#350
Open
midenotch wants to merge 9 commits intoRemitwise-Org:mainfrom
Open
Feature/bills create input validation#350midenotch wants to merge 9 commits intoRemitwise-Org:mainfrom
midenotch wants to merge 9 commits intoRemitwise-Org:mainfrom
Conversation
Enforce explicit create-time constraints for amount, due date, and recurrence combinations with clear error semantics. Add focused validation tests and documentation for edge cases and security assumptions. Made-with: Cursor
Author
|
Done, Close: #350 |
Contributor
|
Please resolve the conflicts |
Contributor
|
@midenotch Please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #267
What I did
Fixed multiple compile blockers in bill_payments/src/lib.rs that prevented any tests from running:
closed malformed event publish blocks
fixed malformed type declarations (BillEvent, StorageStats)
removed duplicate macro derives/const collisions
fixed moved-value usage in emitted events
fixed recurrence-related struct initializers missing external_ref
switched module test wiring to #[cfg(test)] mod test; (using bill_payments/src/test.rs)
Fixed bill_payments/src/test.rs helper typing/return handling for try_create_bill.
Test status
cargo test --manifest-path bill_payments/Cargo.toml -p bill_payments --lib ✅ passes
10 passed; 0 failed