fix: issue #256 - savings goals storage and target date validation#393
Open
menawar wants to merge 1 commit intoRemitwise-Org:mainfrom
Open
fix: issue #256 - savings goals storage and target date validation#393menawar wants to merge 1 commit intoRemitwise-Org:mainfrom
menawar wants to merge 1 commit intoRemitwise-Org:mainfrom
Conversation
Contributor
|
@menawar Please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves failing tests and implements strict target date validation for the
savings_goalscontract. close #256Key Changes
GOALS,NEXT_ID,OWNER_GOAL_IDS, etc.) frominstance()topersistent()storage for better data reliability.create_goalto ensure target dates are in the future and within a 10-year window.init()to startNEXT_IDat 0, ensuring consistent ID generation starting from 1.Verification
lib.rspassing.