Add NodeInjectionService (#153, solution 2)
#233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VelvetToroyashi
force-pushed
the
feat/node-injection
branch
from
4ea1bcc
to
3add51c
Compare
|
I'm kind of still in the solution 3 camp, myself. That said, this is not orthogonal to that and could be merged as a stopgap measure. |
|
The third option is probably the best? Certainly a fair bit more work to implement, so I second this being a stopgap. |
|
You've got some xUnit warnings to take care of. |
|
Closing as moot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for solution 2 mentioned in #153.
I've yet to add tests (should be fairly simple). Solution 1 may have been easier considering interactivity being rewritten to piggyback off of Remora.Commands, but I already had the code written, and hadn't pushed.
If solution one is preferred, 90% of the code can be reused so feel free to poke about that. cc @Nihlus
( Fixes #153 )