Repository navigation
Conversation
Verchiel666
approved these changes
Nov 4, 2026
Verchiel666
left a comment
There was a problem hiding this comment.
Reviewed the full diff against README.en.md — the Japanese translation is accurate and complete:
- All figures check out: 674,976 charts / 8,774,688 readings / 56.6 GB / ~20.4 billion characters (約204億文字), the v3.0 comparison table (+30% / +71% / +17 years / +44%), the 2,160-chart estimation note, and the content version
ca268829f7a9. - All technical details preserved correctly: the true-solar-time late-Zi-hour note (#63) including the 23:30 clock / 22:10 true solar / Hai-hour example, the invalid leap-month policy change (#71),
clock-adjust.tssemantics, thezstd -d --long=27requirement, the sample-dataset known issue (2,520 / 0.49%), and the license table (MIT / CC BY 4.0 / CC BY-NC-SA 4.0 / public domain). - Bilibili timestamps (00:25:27 t=1527, 00:03:15 t=195, 00:25:43 t=1543) and all section links match the English version.
- Language reads naturally and terminology (時辰, 四化, 晩子時, 真太陽時) is rendered consistently.
Two tiny non-blocking nits, fine to leave as-is:
- "起こりえない化に関する文" is slightly ambiguous at first glance — "起こりえない四化に関する文" would be clearer.
- The ouranic.cn links reuse
?from=gh-readme-en; agh-readme-javariant would let you attribute Japanese-README traffic separately, if you track that.
Docs-only change, no code touched, mergeable. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created Japanese translated README.