Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Restcomm#150 : Resubmissions of requests to alternate peers now possible until all peers exhausted, while respecting Weighted Round Robin balancing algorithm #156

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixes Restcomm#150 : Resubmissions of requests to alternate peers now possible until all peers exhausted, while respecting Weighted Round Robin balancing algorithm #156

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d7a3185
Merge pull request #1 from RestComm/master
stevedwyer-nasstar Feb 11, 2020
0e6d72b
Issue: #150 : Diameter error codes 3002 and 3004 are not working as e…
BarisAkkas-kcom Feb 11, 2020
d84b493
Changes reviewed and new Router class added; test added for new Route…
Apr 7, 2020
494866c
New class WeightedRoundRobinResubmittingRouter added to preserve exis…
Apr 8, 2020
6236627
Code reformatted
Apr 8, 2020
b9e42a4
Added check to ensure that the Router implementation can handle submi…
Apr 9, 2020
2575d51
Removed duplicate variable assignment of avpResCode
Apr 20, 2020
3f9fafc
Revert "Removed duplicate variable assignment of avpResCode"
May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/jdiameter/impl/src/main/java/org/jdiameter/client/impl/controller/PeerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,10 +1060,9 @@ public boolean receiveMessage(IMessage message) {
if (isRedirectAnswer(avpResCode, message)) {
message.setListener(request.getEventListener());
message = processRedirectAnswer(request, message);
//if return value is not null, there was some error, lets try to invoke listener if it exists...
// if return value is not null, there was some error, lets try to invoke listener if it exists...
isProcessed = message == null;
}
avpResCode = message.getAvps().getAvp(RESULT_CODE);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering now whether, because if a redirect was processed, the message (i.e. Answer) could possibly be a different message to when avpResCode was originally assigned its value, this assignment statement should be added again, to ensure the avpResCode contains the most recent value, and this particular change reverted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

if (isBusyOrUnableToDeliverAnswer(avpResCode, message)) {
message = processBusyOrUnableToDeliverAnswer(request, message);
// if return value is not null, there was some error, lets try to invoke listener if it exists...
Expand Down