feat(forum): add support for [game=X set=Y] shortcodes #4079
Conversation
|
|
||
| public static function convertGameSetShortcodesToBackingGame(string $input): string | ||
| { | ||
| // Extract all [game=X?set=Y] or [game=X set=Y] patterns. |
There was a problem hiding this comment.
If the pattern is detected, the game portion is ignored.
[game=9999 set=9534]
still maps to the sonic subset.
Should the game association be validated?
Wouldn't it be easier to just have [set=9534]?
There was a problem hiding this comment.
Logically, I think a [set=] shortcode is easier, but I'm afraid it may be more challenging from a UX POV:
- It's one more button.
- We don't expose the set IDs of base sets, which could make the functionality ambiguous or confusing.
Granted, [game=X?set=Y] doesn't feel good from a UX POV either.
There was a problem hiding this comment.
The more I think on this, the more I'm wondering if it's worth simplifying this implementation significantly. Rather than messing with shortcodes, what if we just detect inline game set URLs (whether it's game or game2), and have this functionality only work on those things. That may be an easier UX to explain to folks.
2 participants
This PR adds support for game URLs with set parameters in the forum.
On submit, these are converted to
[game={backingGameId}].