-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Missing Translation Issue #1444
Fix Missing Translation Issue #1444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your (first) contribution!
This generally fixes the problem, but you are solving the symptom rather than the cause in this case.
In case you didn't know, writing t(".title")
resolves to the title
locale of the current view, so it unfolds to the full path moderation.questions.show.title
.
With that in mind, and no other Moderation::QuestionsController
action actually existing, it is safe to rename the locale in https://github.com/Retrospring/retrospring/blob/main/config/locales/views.en.yml#L679 to match the file name here (just show
) so we can keep using the shorthand .title
instead of writing out the full locale path!
6db6bff
to
6d555c5
Compare
Hey @pixeldesu - Thanks for letting me know. I didn't know that 😅 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 174 174
Lines 2702 2702
=======================================
Hits 2578 2578
Misses 124 124 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Resolves #1423
Issue
Fix
Screenshot