Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.4.0. Attribution v2 and nonSubscriptionTransactions #174

Merged
merged 22 commits into from
Sep 23, 2020

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Sep 17, 2020

  • Removes usage of BuildConfig #171
  • Bumped common files to 1.4.2 Changelog here
  • Bumped iOS to 3.7.1 Changelog here
  • Bumped Android to 3.5.0 Changelog here
  • Added a new property nonSubscriptionTransactions in PurchaserInfo to better manage non-subscriptions
  • Attribution V2:
  • Deprecated addAttribution in favor of setAdjustId, setAppsflyerId, setFbAnonymousId, setMparticleId.
  • Added support for OneSignal via setOnesignalId
  • Added setMediaSource, setCampaign, setAdGroup, setAd, setKeyword, setCreative, and collectDeviceIdentifiers

@vegaro vegaro marked this pull request as draft September 17, 2020 21:57
@vegaro vegaro changed the title Attribution v2 and nonSubscriptionTransactions in urchaserinfo Attribution v2 and nonSubscriptionTransactions in PurchaserInfo Sep 17, 2020
@vegaro vegaro added this to the 3.4.0 milestone Sep 17, 2020
@vegaro vegaro changed the base branch from develop to update September 17, 2020 21:58
@vegaro vegaro changed the title Attribution v2 and nonSubscriptionTransactions in PurchaserInfo Version 3.4.0. Attribution v2 and nonSubscriptionTransactions in PurchaserInfo Sep 17, 2020
@vegaro vegaro changed the title Version 3.4.0. Attribution v2 and nonSubscriptionTransactions in PurchaserInfo Version 3.4.0. Attribution v2 and nonSubscriptionTransactions Sep 17, 2020
@vegaro vegaro marked this pull request as ready for review September 19, 2020 00:12
@vegaro vegaro requested a review from aboedo September 19, 2020 00:59
Base automatically changed from update to develop September 21, 2020 18:59
# - >-
# yarn-cache-{{ arch }}-{{ checksum "~/.tmp/checksumfiles/package.json"
# }}-{{ checksum "~/.tmp/checksumfiles/yarn.lock" }}-{{
# .Environment.CACHE_VERSION }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is failing, still don't know why. I have tried by using /tmp/yarn and ./tmp/yarn with the same results.

The orb has an open issue about it, so I will monitor and see if they fix it react-native-community/react-native-circleci-orb#66, until the, I think we can live without the caches

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a comment and a link to react-native-community/react-native-circleci-orb#66 to the code here, so that when we look back at it we understand why it's commented and we check if it has been fixed

DEVELOPMENT_TEAM = 8SXR2327BM;
INFOPLIST_FILE = ReactNativeSample/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 4.0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I increased the version when validating. I can rollback if necessary, but I don't think it hurts

Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great so far, left a couple of comments

# - >-
# yarn-cache-{{ arch }}-{{ checksum "~/.tmp/checksumfiles/package.json"
# }}-{{ checksum "~/.tmp/checksumfiles/yarn.lock" }}-{{
# .Environment.CACHE_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a comment and a link to react-native-community/react-native-circleci-orb#66 to the code here, so that when we look back at it we understand why it's commented and we check if it has been fixed

ios/RNPurchases.m Show resolved Hide resolved
@vegaro vegaro requested a review from aboedo September 21, 2020 21:11
@vegaro vegaro merged commit aed5696 into develop Sep 23, 2020
@vegaro vegaro deleted the attribution_purchaserinfo branch September 23, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants