-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.4.0. Attribution v2 and nonSubscriptionTransactions #174
Conversation
This reverts commit 4d0ae1a.
4b7b0a5
to
de05bfe
Compare
# - >- | ||
# yarn-cache-{{ arch }}-{{ checksum "~/.tmp/checksumfiles/package.json" | ||
# }}-{{ checksum "~/.tmp/checksumfiles/yarn.lock" }}-{{ | ||
# .Environment.CACHE_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is failing, still don't know why. I have tried by using /tmp/yarn
and ./tmp/yarn
with the same results.
The orb has an open issue about it, so I will monitor and see if they fix it react-native-community/react-native-circleci-orb#66, until the, I think we can live without the caches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a comment and a link to react-native-community/react-native-circleci-orb#66 to the code here, so that when we look back at it we understand why it's commented and we check if it has been fixed
DEVELOPMENT_TEAM = 8SXR2327BM; | ||
INFOPLIST_FILE = ReactNativeSample/Info.plist; | ||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | ||
MARKETING_VERSION = 4.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I increased the version when validating. I can rollback if necessary, but I don't think it hurts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great so far, left a couple of comments
# - >- | ||
# yarn-cache-{{ arch }}-{{ checksum "~/.tmp/checksumfiles/package.json" | ||
# }}-{{ checksum "~/.tmp/checksumfiles/yarn.lock" }}-{{ | ||
# .Environment.CACHE_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a comment and a link to react-native-community/react-native-circleci-orb#66 to the code here, so that when we look back at it we understand why it's commented and we check if it has been fixed
nonSubscriptionTransactions
inPurchaserInfo
to better manage non-subscriptions