support domain in the address

RicYaben · Oct 18, 2024 · d6b82ae · d6b82ae
1 parent a125e7f
commit d6b82ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/modules/mqtt/mqtt_test.go b/modules/mqtt/mqtt_test.go
@@ -2,14 +2,14 @@
 package mqtt
 
 import (
-	"net"
 	"testing"
 	"time"
 
 	"github.com/zmap/zgrab2"
 )
 
 type mqttTester struct {
+	addr           string
 	port           int
 	expectedStatus zgrab2.ScanStatus
 }
@@ -49,7 +49,7 @@ func (t *mqttTester) runTest(test *testing.T, name string) {
 	}
 
 	target := zgrab2.ScanTarget{
-		IP: net.ParseIP("127.0.0.1"),
+		Domain: t.addr,
 	}
 
 	status, ret, err := scanner.Scan(target)
@@ -68,6 +68,7 @@ func (t *mqttTester) runTest(test *testing.T, name string) {
 
 var tests = map[string]*mqttTester{
 	"success": {
+		addr:           "test.mosquitto.org",
 		port:           1883,
 		expectedStatus: zgrab2.SCAN_SUCCESS,
 	},

diff --git a/modules/mqtt/scanner.go b/modules/mqtt/scanner.go
@@ -117,7 +117,7 @@ func (scan *scan) makeClient() (paho.Client, error) {
 	if scan.target.Port != nil {
 		port = scan.target.Port
 	}
-	t := fmt.Sprintf("%s://%s:%d", scheme, scan.target.IP.String(), *port)
+	t := fmt.Sprintf("%s://%s:%d", scheme, scan.target.Host(), *port)
 	o.AddBroker(t)
 
 	// Add auth details