-
Notifications
You must be signed in to change notification settings - Fork 274
feat: passthrough unknown slash commands to Claude in agentic mode #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haripatel07
wants to merge
5
commits into
RichardAtCT:main
Choose a base branch
from
haripatel07:feat/passthrough-unknown-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f746080
feat: passthrough unknown slash commands to Claude in agentic mode
haripatel07 db9a076
fix: use fallback CommandHandler to avoid double-fire on known commands
haripatel07 de8924d
fix: address review feedback - dynamic known commands, ClassVar annot…
haripatel07 22d16ee
fix: remove unused ClassVar import
haripatel07 60d794e
fix: initialise _known_commands in __init__ to guard against Attribut…
haripatel07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Removing
~filters.COMMANDwill cause registered slash commands (e.g./start,/new,/status,/verbose,/repo,/restart) to be processed twice — once by theCommandHandlerin the default group (0) and again byagentic_textin group 10.In python-telegram-bot, handler groups are independent: a match in group 0 does not prevent handlers in group 10 from also firing. Only
ApplicationHandlerStopcan stop cross-group propagation, and it is not raised anywhere in this codebase.This means typing
/startwill both runagentic_startand send "/start" to Claude as a text message.To fix this while still passing through unknown slash commands, you should keep
~filters.COMMANDbut add a fallbackMessageHandlerwithfilters.COMMANDin the same group (10) that only fires for unrecognised commands. Alternatively, you could move theCommandHandlers into group 10 as well (so they share the same group as the text handler and block it), or raiseApplicationHandlerStopin each command handler to prevent further group processing.