Skip to content

Set concurrency to nproc*2 in SQS broker if < 1 #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zxia-wish wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −0
Open

Set concurrency to nproc*2 in SQS broker if < 1 #738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b1aa8
Set concurrency to nproc*2 in SQS broker if < 1
zxia-wish Jan 6, 2022
1b0d658
Default concurrency to use GOMAXPROCS in SQS broker
zxia-wish Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions v1/brokers/sqs/sqs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/json"
"errors"
"fmt"
"runtime"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -59,6 +60,9 @@ func New(cnf *config.Config) iface.Broker {

// StartConsuming enters a loop and waits for incoming messages
func (b *Broker) StartConsuming(consumerTag string, concurrency int, taskProcessor iface.TaskProcessor) (bool, error) {
if concurrency < 1 {
concurrency = runtime.GOMAXPROCS(0)
}
b.Broker.StartConsuming(consumerTag, concurrency, taskProcessor)
qURL := b.getQueueURL(taskProcessor)
//save it so that it can be used later when attempting to delete task
Expand Down