Skip to content

feat(broker): Add early ack support #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akkuman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(broker): Add early ack support #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion v1/brokers/amqp/amqp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,11 @@ func (b *Broker) consumeOne(delivery amqp.Delivery, taskProcessor iface.TaskProc

log.DEBUG.Printf("Received new message: %s", delivery.Body)

if ack && b.GetConfig().AMQP.EarlyAck {
delivery.Ack(multiple)
}
err := taskProcessor.Process(signature)
if ack {
if ack && !b.GetConfig().AMQP.EarlyAck {
delivery.Ack(multiple)
}
return err
Expand Down
1 change: 1 addition & 0 deletions v1/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ type AMQPConfig struct {
BindingKey string `yaml:"binding_key" envconfig:"AMQP_BINDING_KEY"`
PrefetchCount int `yaml:"prefetch_count" envconfig:"AMQP_PREFETCH_COUNT"`
AutoDelete bool `yaml:"auto_delete" envconfig:"AMQP_AUTO_DELETE"`
EarlyAck bool `yaml:"early_ack" envconfig:"AMQP_EARLY_ACK"`
}

// DynamoDBConfig wraps DynamoDB related configuration
Expand Down