Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error in IstioMatches handling. #6

Merged
merged 1 commit into from
Jan 29, 2024
+18 −14
Merged

Fixed an error in IstioMatches handling. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions docs/advanced/technical-overview.md
View file
Original file line number Diff line number Diff line change
@@ -23,11 +23,9 @@ this section to prevent confusion:
### IstioMatches

IstioMatches corresponds to a subset of [Istio's HTTPMatchRequest][match] (specifically _headers_
and _source labels_). Currently, _DynamicEnvironment_ IstioMatches are translated to
HTTPMatchRequest as follows:

* All headers are grouped into a single HTTPMatchRequest.
* All source labels are grouped into a single HTTPMatchRequest.
and _source labels_). _DynamicEnvironment_'s IstioMatches are translated to HTTPMatchRequest as
follows, each item in the list of istio matches (regardless if it consists of headers, source
labels, or both) corresponds to a single HttpMatchRequest.

So, if you have the following IstioMatches object:

@@ -37,8 +35,10 @@ spec:
istioMatches:
- headers:
end-user:
- sourceLabels:
sourceLabels:
end-user: json
- sourceLabels:
end-user: joe
[ ... ]
```

@@ -52,12 +52,14 @@ spec:
- headers:
end-user:
prefix: jason
sourceLabels:
end-user: json
route:
- destination:
[ ... ]
- match:
- sourceLabels:
end-user: json
end-user: joe
route:
- destination:
[ ... ]
16 changes: 9 additions & 7 deletions versioned_docs/version-0.1.0/advanced/technical-overview.md
View file
Original file line number Diff line number Diff line change
@@ -23,11 +23,9 @@ this section to prevent confusion:
### IstioMatches

IstioMatches corresponds to a subset of [Istio's HTTPMatchRequest][match] (specifically _headers_
and _source labels_). Currently, _DynamicEnvironment_ IstioMatches are translated to
HTTPMatchRequest as follows:

* All headers are grouped into a single HTTPMatchRequest.
* All source labels are grouped into a single HTTPMatchRequest.
and _source labels_). _DynamicEnvironment_'s IstioMatches are translated to HTTPMatchRequest as
follows, each item in the list of istio matches (regardless if it consists of headers, source
labels, or both) corresponds to a single HttpMatchRequest.

So, if you have the following IstioMatches object:

@@ -37,8 +35,10 @@ spec:
istioMatches:
- headers:
end-user:
- sourceLabels:
sourceLabels:
end-user: json
- sourceLabels:
end-user: joe
[ ... ]
```

@@ -52,12 +52,14 @@ spec:
- headers:
end-user:
prefix: jason
sourceLabels:
end-user: json
route:
- destination:
[ ... ]
- match:
- sourceLabels:
end-user: json
end-user: joe
route:
- destination:
[ ... ]