Merge pull request #79 from Riskified/DEV-32224

Depreciated Payment_type
Riskified · Apr 15, 2022 · 89c7bfd · 89c7bfd
2 parents f2c0770 + be9965e
commit 89c7bfd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 16 deletions.
diff --git a/Riskified.SDK/Model/OrderElements/CreditCardPaymentDetails.cs b/Riskified.SDK/Model/OrderElements/CreditCardPaymentDetails.cs
@@ -8,7 +8,7 @@
 
 namespace Riskified.SDK.Model.OrderElements
 {
-
+    [Obsolete("PaymentType not in use anymore", true)]
     public enum PaymentType
     {
         credit_card, paypal
@@ -47,7 +47,6 @@ public CreditCardPaymentDetails(string avsResultCode,
             StoredPaymentCreatedAt = storedPaymentCreatedAt;
             StoredPaymentUpdatedAt = storedPaymentUpdatedAt;
             Installments = installments;
-            PaymentType = PaymentType.credit_card;
         }
 
 
@@ -71,11 +70,7 @@ public void Validate(Validations validationType = Validations.Weak)
         }
 
 
-
-        [JsonProperty(PropertyName = "payment_type")]
-        [JsonConverter(typeof(StringEnumConverter))]
-        public PaymentType PaymentType { get; set; }
-
+
         [JsonProperty(PropertyName = "avs_result_code")]
         public string AvsResultCode { get; set; }
 

diff --git a/Riskified.SDK/Model/OrderElements/PaymentType.cs b/Riskified.SDK/Model/OrderElements/PaymentType.cs
@@ -3,7 +3,7 @@
 
 namespace Riskified.SDK.Model.OrderElements
 {
-
+    [Obsolete("payment_type not in use anymore", true)]
     public enum PaymentType
     {
         [EnumMember(Value = "paypal")]

diff --git a/Riskified.SDK/Model/OrderElements/PaypalPaymentDetails.cs b/Riskified.SDK/Model/OrderElements/PaypalPaymentDetails.cs
@@ -1,4 +1,5 @@
-using Newtonsoft.Json;
+using System;
+using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
 using Riskified.SDK.Exceptions;
 using Riskified.SDK.Model.OrderCheckoutElements;
@@ -28,7 +29,6 @@ public PaypalPaymentDetails(string paymentStatus, string authorizationId = null,
             ProtectionEligibility = protectionEligibility;
             PaymentStatus = paymentStatus;
             PendingReason = PendingReason;
-            PaymentType = PaymentType.paypal;
         }
 
         /// <summary>
@@ -44,10 +44,7 @@ public void Validate(Validations validationType = Validations.Weak)
             }
         }
 
-        [JsonProperty(PropertyName = "payment_type")]
-        [JsonConverter(typeof(StringEnumConverter))]
-        public PaymentType PaymentType { get; set; }
-
+
         [JsonProperty(PropertyName = "authorization_id")]
         public string AuthorizationId { get; set; }
 

diff --git a/Riskified.SDK/Properties/AssemblyInfo.cs b/Riskified.SDK/Properties/AssemblyInfo.cs
@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("3.3.0")]
-[assembly: AssemblyFileVersion("3.3.0")]
+[assembly: AssemblyVersion("3.3.1")]
+[assembly: AssemblyFileVersion("3.3.1")]