Skip to content

Fix Critical Vul : Null Signature #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Critical Vul : Null Signature #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions contracts/core/PasskeyVerificationLibrary.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ library Secp256r1 {
uint256 constant MOST_SIGNIFICANT = 0xc000000000000000000000000000000000000000000000000000000000000000;



function Verify(Passkey memory passKey, uint r, uint s, uint e)
internal view returns (bool)
{
if (r >= nn || s >= nn) {
if (r==0 || s== 0 ||r >= nn || s >= nn) {/* testing null signature, otherwise (0,0) is valid for any message*/
return false;
}

Expand All @@ -46,7 +47,7 @@ library Secp256r1 {
function VerifyWithPrecompute(JPoint[16] memory points, uint r, uint s, uint e)
internal view returns (bool)
{
if (r >= nn || s >= nn) {
if (r==0 || s== 0 ||r >= nn || s >= nn) {/* testing null signature, otherwise (0,0) is valid for any message*/
return false;
}

Expand Down Expand Up @@ -310,4 +311,4 @@ library Secp256r1 {
}
}

}
}