Merge pull request #297 from RoadieHQ/fix-bad-entity-error

Fix unhelpful error
RoadieHQ · Nov 29, 2021 · 4c94940 · 4c94940
2 parents a66a56a + 212fb22
commit 4c94940
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/utils/roadie-backstage-entity-validator/package.json b/utils/roadie-backstage-entity-validator/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@roadiehq/roadie-backstage-entity-validator",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "author": "RoadieHQ",
   "description": "Backstage entity validator library",
   "main": "src/index.js",

diff --git a/utils/roadie-backstage-entity-validator/src/validator.js b/utils/roadie-backstage-entity-validator/src/validator.js
@@ -37,7 +37,7 @@ function modifyPlaceholders(obj) {
           return;
         }
       } catch(e) {
-        throw new Error(`Placeholder with name ${k} is empty. Please remove it or populate it.`)
+        throw new Error(`Placeholder with name '${k}' is empty. Please remove it or populate it.`)
       }
       modifyPlaceholders(obj[k]);
     }

diff --git a/utils/roadie-backstage-entity-validator/src/validator.test.js b/utils/roadie-backstage-entity-validator/src/validator.test.js
@@ -14,7 +14,7 @@ describe('validator',  () => {
   });
 
   it('Should fail to validate with incorrect catalog-info that has an empty label', async () => {
-    await expect(validator.validateFromFile('./sample/catalog-info-with-empty-label.yml')).rejects.toThrow("Error: Placeholder with name definition is empty. Please remove it or populate it.");
+    await expect(validator.validateFromFile('./sample/catalog-info-with-empty-label.yml')).rejects.toThrow("Error: Placeholder with name 'definition' is empty. Please remove it or populate it.");
   });
 })