Merge pull request #1039 from janhoon/fix/argo-frontend-helm

fix(argo-frontend-plugin): skip helm revision metadata
RoadieHQ · Jul 21, 2023 · e2a2c7a · e2a2c7a
2 parents 42ae767 + 0fe8b68
commit e2a2c7a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/cool-coins-protect.md b/.changeset/cool-coins-protect.md
@@ -0,0 +1,5 @@
+---
+'@roadiehq/backstage-plugin-argo-cd': patch
+---
+
+Fix for cases where argo application history source is Helm, which would cause revision metadata api to return 500
diff --git a/plugins/frontend/backstage-plugin-argo-cd/src/components/useAppDetails.ts b/plugins/frontend/backstage-plugin-argo-cd/src/components/useAppDetails.ts
@@ -42,6 +42,10 @@ export const useAppDetails = ({
     const promises: Promise<void>[] | undefined =
       appDetails.status?.history?.map(async (historyRecord: any) => {
         const revisionID = historyRecord.revision;
+        if (historyRecord.source?.chart !== undefined) {
+          historyRecord.revision = { revisionID: revisionID };
+          return;
+        }
         const revisionDetails = await api.getRevisionDetails({
           url,
           app,