new backend for scaffolder-backend-argocd #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solthoth
approved these changes
Sep 23, 2024
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
vanessap-aa
reviewed
Oct 2, 2024
plugins/scaffolder-actions/scaffolder-backend-argocd/src/new-backend.ts
Outdated
Show resolved
Hide resolved
vanessap-aa
reviewed
Oct 2, 2024
plugins/scaffolder-actions/scaffolder-backend-argocd/src/new-backend.ts
Outdated
Show resolved
Hide resolved
|
@htplbc would you mind updating the branch with main? |
karlhaworth
previously approved these changes
Oct 3, 2024
vanessap-aa
reviewed
Oct 3, 2024
plugins/scaffolder-actions/scaffolder-backend-argocd/src/new-backend.ts
Outdated
Show resolved
Hide resolved
vanessap-aa
suggested changes
Oct 3, 2024
vanessap-aa
reviewed
Oct 3, 2024
plugins/scaffolder-actions/scaffolder-backend-argocd/package.json
Outdated
Show resolved
Hide resolved
vanessap-aa
reviewed
Oct 3, 2024
plugins/scaffolder-actions/scaffolder-backend-argocd/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Vanessa Plugues <[email protected]>
Co-authored-by: Vanessa Plugues <[email protected]>
karlhaworth
approved these changes
Oct 7, 2024
Xantier
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Checklist
yarn changesetin the root)