Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign in button in entity GitHub related cards #1665

Conversation

florinnania
Copy link
Contributor

@florinnania florinnania commented Oct 11, 2024

Before:
Screenshot 2024-10-13 at 23 54 32
Screenshot 2024-10-13 at 23 55 10

After:
Screenshot 2024-10-11 at 23 57 55

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@florinnania florinnania requested a review from a team as a code owner October 11, 2024 21:24
@florinnania florinnania marked this pull request as draft October 12, 2024 10:53
@florinnania florinnania marked this pull request as ready for review October 13, 2024 21:01
@Xantier Xantier merged commit d3307d4 into RoadieHQ:main Oct 15, 2024
2 checks passed
florinnania pushed a commit to florinnania/roadie-backstage-plugins that referenced this pull request Oct 22, 2024
Xantier added a commit that referenced this pull request Oct 23, 2024
…or-ContributorsCard-in-EntityPage

Fix for #1665 to not trigger login required for contributors card in entity page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants