feat(rag-ai): allow specifying custom openai url #1700
Merged
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pc-bob
force-pushed
the
BL/custom-openai-url
branch
from
78a1406
to
c48760a
Compare
pc-bob
force-pushed
the
BL/custom-openai-url
branch
from
c48760a
to
6da7661
Compare
punkle
reviewed
Oct 26, 2024
| openAIApiKey: 'sk-123...' | ||
| openAiApiKey: 'sk-123...' | ||
|
|
||
| # (Optional) Specify URL of self-hosted OpenAI compliant endpoint. Defaults to OpenAI's public API https://api.openai.com |
There was a problem hiding this comment.
Please mention what the default state is.
There was a problem hiding this comment.
is this not sufficient? Defaults to OpenAI's public API https://api.openai.com
There was a problem hiding this comment.
Ah sorry. Somehow i missed that.
There was a problem hiding this comment.
Ah sorry. Somehow i missed that.
|
@punkle anything else needed to get this merged? |
punkle
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1469
Makes the baseURL for OpenAi configurable to allow use of a self-hosted OpenAI endpoint.
Verified functionality using a self-hosted OpenAI URL:
rag-ai.mov
✔️ Checklist
yarn changesetin the root)