fix(security-insights): set filtered table data on initial load #1707
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated this component to filter to
open
on initial load. However, on initial load onlytableData
was being set previously.Fixes: #1492
There is a check in the JSX to render
filteredTableData
ifinsightsStatusFilter
is set. SinceinsightsStatusFilter
is set with the default state value now (const [insightsStatusFilter, setInsightsStatusFilter] = useState<SecurityInsightFilterState>('open');
), this was renderingfilteredTableData
on the first render which was null. Clicking onOpen
would display data but may give uses a false sense of security that they have no security insights with a quick glance at the tab.✔️ Checklist
yarn changeset
in the root)