Handle errors better

.changeset/spotty-ducks-smell.md

@@ -0,0 +1,5 @@
+---
+'@roadiehq/scaffolder-backend-module-http-request': patch
+---
+
+Respect continueOnBadResponse for any error thrown by request and ensure we log the error

plugins/scaffolder-actions/scaffolder-backend-module-http-request/src/actions/run/backstageRequest.ts

@@ -139,60 +139,70 @@ export function createHttpBackstageAction(options: {
         );
       }
 
-      const queryParams: string = params
-        ? new URLSearchParams(params).toString()
-        : '';
+      try {
+        const queryParams: string = params
+          ? new URLSearchParams(params).toString()
+          : '';
 
-      let inputBody: Body = undefined;
+        let inputBody: Body = undefined;
 
-      if (
-        input.body &&
-        typeof input.body !== 'string' &&
-        input.headers &&
-        input.headers['content-type'] &&
-        input.headers['content-type'].includes('application/json')
-      ) {
-        inputBody = JSON.stringify(input.body);
-      } else {
-        inputBody = input.body;
-      }
+        if (
+          input.body &&
+          typeof input.body !== 'string' &&
+          input.headers &&
+          input.headers['content-type'] &&
+          input.headers['content-type'].includes('application/json')
+        ) {
+          inputBody = JSON.stringify(input.body);
+        } else {
+          inputBody = input.body;
+        }
 
-      const httpOptions: HttpOptions = {
-        method: input.method,
-        url: queryParams !== '' ? `${url}?${queryParams}` : url,
-        headers: input.headers ? (input.headers as Headers) : {},
-        body: inputBody,
-      };
+        const httpOptions: HttpOptions = {
+          method: input.method,
+          url: queryParams !== '' ? `${url}?${queryParams}` : url,
+          headers: input.headers ? (input.headers as Headers) : {},
+          body: inputBody,
+        };
 
-      const authToken = getObjFieldCaseInsensitively(
-        input.headers,
-        'authorization',
-      );
+        const authToken = getObjFieldCaseInsensitively(
+          input.headers,
+          'authorization',
+        );
 
-      if (token && !authToken) {
-        ctx.logger.info(`Token is defined. Setting authorization header.`);
-        httpOptions.headers.authorization = `Bearer ${token}`;
-      }
+        if (token && !authToken) {
+          ctx.logger.info(`Token is defined. Setting authorization header.`);
+          httpOptions.headers.authorization = `Bearer ${token}`;
+        }
 
-      const dryRunSafeMethods = new Set(['GET', 'HEAD', 'OPTIONS']);
-      if (ctx.isDryRun === true && !dryRunSafeMethods.has(method)) {
-        ctx.logger.info(
-          `Dry run mode. Skipping non dry-run safe method '${method}' request to ${
-            queryParams !== '' ? `${input.path}?${queryParams}` : input.path
-          }`,
+        const dryRunSafeMethods = new Set(['GET', 'HEAD', 'OPTIONS']);
+        if (ctx.isDryRun === true && !dryRunSafeMethods.has(method)) {
+          ctx.logger.info(
+            `Dry run mode. Skipping non dry-run safe method '${method}' request to ${
+              queryParams !== '' ? `${input.path}?${queryParams}` : input.path
+            }`,
+          );
+          return;
+        }
+
+        const { code, headers, body } = await http(
+          httpOptions,
+          ctx.logger,
+          continueOnBadResponse,
         );
-        return;
+        ctx.output('code', code);
+        ctx.output('headers', headers);
+        ctx.output('body', body);
+      } catch (e: any) {
+        ctx.logger.error(`Action failed due to unhandled error: ${e?.message}`);
+        if (continueOnBadResponse) {
+          ctx.output('code', 500);
+          ctx.output('headers', {});
+          ctx.output('body', { error: e?.message });
+        } else {
+          throw e;
+        }
       }
-
-      const { code, headers, body } = await http(
-        httpOptions,
-        ctx.logger,
-        continueOnBadResponse,
-      );
-
-      ctx.output('code', code);
-      ctx.output('headers', headers);
-      ctx.output('body', body);
     },
   });
 }