Add capacitor #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaredgalanis
commented
Jul 1, 2020
•
jaredgalanis
commented
- adds capacitor and required plugins to get a mobile version of the app working
- TODOs:
- styling fixes on mobile
- remove extraneous plugins
- provide attribution for base64Decoder
- do files need to be cleaned up in the local filesystem (no they are stored in a tmp dir which gets cleaned up)
- fix mic permissions grant - don't use window for OfflineAudioContext if not webkit
we actually do need it here
app/components/audio-capturer.js
Outdated
| let result = await VoiceRecorder.stopRecording(); | ||
| let byteArray = Base64Binary.decodeArrayBuffer(result.value.recordDataBase64); | ||
|
|
||
| this.args.uploadAudioVideo(byteArray); |
There was a problem hiding this comment.
@jaredgalanis shouldn't this match the format from before where it's an object with blob as the key? this.args.uploadAudioVideo({ blob: e.data });
I think if we pass the same data format, we can ensure that it should draw the same.
There was a problem hiding this comment.
So I tried passing instantiating a Blob with the ArrayBuffer that we get out of converting the base64 string with this in mind, but it didn't work unfortunately.
| @@ -5,7 +5,7 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <title>Wuf</title> | |||
| <meta name="description" content=""> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover"> | |||
There was a problem hiding this comment.
What does this do? I haven't used it before.
There was a problem hiding this comment.
This is part of what allows the app to respect the safeareas of the notch in an iPhone X or 11.
- file upload was broken by a previous commit, need to pull the blob off a data object since that's what the file input provides - remove stray import to fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.