Skip to content

fix(ci): install from the lockfile #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jfrench9 wants to merge 1 commit into from
Closed

fix(ci): install from the lockfile #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ jobs:

- name: Install dependencies
if: steps.check-published.outputs.already_published == 'false'
run: npm install
# npm ci installs exactly what the lockfile says. `npm install` re-resolved
# peers on every run, so an upstream publish could break CI between a
# PR's green run and its merge (2026-09-09: react-dom 19.3.0 arrived
# two minutes before react 19.3.0 did).
run: npm ci

- name: Build
if: steps.check-published.outputs.already_published == 'false'
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ jobs:
run: npm install -g npm@11

- name: Install dependencies
run: npm install
# npm ci installs exactly what the lockfile says. `npm install` re-resolved
# peers on every run, so an upstream publish could break CI between a
# PR's green run and its merge (2026-09-09: react-dom 19.3.0 arrived
# two minutes before react 19.3.0 did).
run: npm ci

- name: Check formatting
run: npm run format:check
Expand Down
Loading