Skip to content

feat(loop): print the MCP URL for sign-in; the header key is opt-in - #7

Merged
jfrench9 merged 2 commits into
mainfrom
feature/oauth-instead-of-connector-url
Aug 26, 2026
Merged

jfrench9 merged 2 commits into
mainfrom
feature/oauth-instead-of-connector-url

Conversation

@jfrench9

Copy link
Copy Markdown
Member

Companion to RoboFinSystems/robosystems#1268 (the ?token= connector URL is retired).

  • up records mcp_url in the state file and prints it: add it in Claude (custom connector) or Claude Code, sign in as the demo account — the graph is preselected on the consent screen.
  • A graph-scoped API key is minted only with --connector-key (header-only clients), and stored as connector_key; the default leaves no credential behind, which is what CI wants. --no-connector is still accepted as a no-op so old invocations keep working.
  • down still revokes through connector_key_id; a legacy connector_url in an existing state file is dropped on the next up.

just test-all green.

The API is retiring the ?token= connector URL (robosystems #1268), so
the loop stops minting one. up now records and prints the graph's MCP
URL — add it in Claude or Claude Code and sign in as the demo account,
the graph is preselected — and mints a graph-scoped key only with
--connector-key, for clients that cannot sign in. Off by default so CI
logs never carry a credential; --no-connector is accepted as a no-op.
…flag

Completes the previous commit, which changed mint_connector_key's return
shape without updating its caller.
@jfrench9
jfrench9 merged commit d440df5 into main Aug 26, 2026
4 checks passed
@jfrench9
jfrench9 deleted the feature/oauth-instead-of-connector-url branch August 27, 2026 23:21
jfrench9 added a commit that referenced this pull request Aug 31, 2026
The `?token=` retirement landed in the code (#7) but left stale copy
behind it. The Demo workflow still told operators to "generate the
connector URL from the app's Connect page" — a page that now mints a
header key, not a URL — and passed the retired `--no-connector` no-op.
The README, justfile and package docstring still called the handoff a
connector URL.

The handoff is now stated once, consistently: `demo-up` prints the
per-graph MCP URL, the client adds it and signs in as the demo account,
and consent names the tenant because the URL pins the graph. The URL is
not a credential, so the CI summary prints it in its own column.

`--connector-key` stays. OAuth covers MCP clients only, so a viewer who
cannot sign in as the demo account still needs a header key (Claude's
"Additional request headers", a Cursor/VS Code mcp.json) — and the
loop's own ROBOSYSTEMS_API_KEY is untouched by OAuth either way, since
provisioning, loading and teardown are ordinary REST.

Both hand-rolled httpx calls move onto typed SDK ops: client 1.12.0
carries `graph_id` on CreateAPIKeyRequest, so the escape hatch that
mint_connector_key documented no longer exists. Same endpoints, same
error handling as the other calls in the module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant