Skip to content

chore(ci): call the shared claude-review workflow - #74

Merged
jfrench9 merged 1 commit into
mainfrom
chore/shared-claude-review
Sep 2, 2026
Merged

jfrench9 merged 1 commit into
mainfrom
chore/shared-claude-review

Conversation

@jfrench9

@jfrench9 jfrench9 commented Sep 2, 2026

Copy link
Copy Markdown
Member

Reduces claude.yml to its triggers plus the permissions grant ( 54 → 28 lines). The author gate, runner selection, and the claude-code-action / checkout pins now come from RoboFinSystems/robosystems/.github/workflows/claude-review.yml.

Also picks up the SHA-pinned checkout — this repo was on the mutable actions/checkout@v7 tag.

No behaviour change: the gate and permissions are identical, and select-runner returns ["ubuntu-latest"] without an API call while RUNNER_LABELS is github-hosted.

Verified end to end in robosystems (run 33592717239: check-runner-availabilityclaude, both green) and piloted in robosystems-python-client#206.

Reduces claude.yml to its triggers and permissions grant; the author
gate, runner selection and the claude-code-action and checkout pins now
come from RoboFinSystems/robosystems/.github/workflows/claude-review.yml,
where they are maintained once rather than in each repo.

Also picks up the SHA-pinned checkout from the shared workflow - this
repo was on the mutable actions/checkout@v7 tag.

No behaviour change: the gate and permissions are identical, and
select-runner returns ["ubuntu-latest"] without an API call while
RUNNER_LABELS is github-hosted.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113UQ7evQKHNf1L1tFiZzLD
@jfrench9
jfrench9 merged commit c746e93 into main Sep 2, 2026
5 checks passed
@jfrench9
jfrench9 deleted the chore/shared-claude-review branch September 2, 2026 05:26
jfrench9 added a commit that referenced this pull request Sep 2, 2026
Deletes this repo's copy of `tag-release.yml` (~400 lines) and calls the
shared one in `robosystems`.

**This is how the release-notes fix reaches this repo.** The local copy
extracted the changelog with `.content[0].text`, which assumes the first
content block is text. Once `CLAUDE_MODEL` moved to a model that thinks
by default, responses lead with a thinking block, so that returned
`null` and tripped the empty-content fallback — every release here has
been emitting bare commit stats since early August.

## It also fixes the wrong product identity

The copy here was inherited from the web app repo and never re-pointed.
It told Claude:

- `- App: RoboSystems (Comprehensive financial platform hub web
application)`
- "a **Next.js SDK library** release"
- `- **Live App:** [robosystems.ai](https://robosystems.ai)`

None of which describe an MCP client. Even with the parser fixed, this
repo would have generated notes about the wrong product and linked the
wrong site. It now passes `product_name: 'RoboSystems MCP Client'` and
`project_kind: 'MCP client SDK'`, with no live link.

## ⚠️ Merge order

**RoboFinSystems/robosystems#1344 must merge first** — the shared
workflow needs the new inputs, and merging this first would fail the
next release rather than just degrade it.

Independent of #74 (the `claude.yml` change), which is on a separate
branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant