fix: hide XBRL hypercube scaffolding rows (Table / Line Items) - #19
Merged
Merged
Conversation
Stripping the role tags exposed that us-gaap:StatementTable and us-gaap:StatementLineItems render as bare, duplicated 'Statement' header rows — pure hypercube plumbing that carries no facts and is not a meaningful heading. Skip these abstracts in the pivot row walk and keep their children at the current depth so the tree stays flat. The check keys off the concept's local name (…Table / …LineItems), which is identical whether elements are keyed by IRI (store/holon route) or qname (SEC route), so both rendering routes hide them the same way. Axis/Domain/Member/Abstract/Roll Forward rows are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #17. Stripping the XBRL role tags from labels (0.2.8) exposed that
us-gaap:StatementTableandus-gaap:StatementLineItemsrender as bare, duplicated "Statement" header rows in the statement body — visible in both the file/holon route and the SEC route (AAPL 10-K and 10-Q). These are pure hypercube plumbing: the[Table]is the hypercube itself and[Line Items]is its container; neither carries facts, and neither is a meaningful heading.Change
buildPivotrow walk, skip emitting a header row for abstract concepts whose local name ends inTableorLineItems, and keep their children at the current depth so the tree doesn't over-indent.[Axis]/[Domain]/[Member]/[Abstract]/[Roll Forward]rows are untouched — those carry real names/data.Before → after (AAPL income statement)
Verification
buildPivottests (qname-keyed, mirroring the SEC route): no header row for the plumbing, real header + concepts retained, children promoted to the scaffold's depth rather than over-indented.test:all(format, lint, typecheck, 75 tests, build) passes.