Skip to content

chore(examples): regenerate the demo holon samples through xbrlkit - #1374

Closed
jfrench9 wants to merge 1 commit into
mainfrom
chore/holon-samples-regen
Closed

chore(examples): regenerate the demo holon samples through xbrlkit#1374
jfrench9 wants to merge 1 commit into
mainfrom
chore/holon-samples-regen

Conversation

@jfrench9

@jfrench9 jfrench9 commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #1373. The other four tracked .holon.jsonld samples were still the old partition's output — each missing 52–59 element declarations for the rows its arcs reach. Regenerated offline from the flat JSON-LD beside each, through write_holon_jsonld (the DataBook converter), the same path the SaaS sample took in #1373. No code change.

sample undeclared endpoints before after concepts / labelled
coffee-roaster-demo 56 0 101 / 93
roboledger-demo 59 0 93 / 93
seattle-method-case-1 52 0 93 / 93
world-online 58 0 93 / 93

Each file loads in xbrlkit with the report id as its accession; facts are unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VQNt2hdNJqbJwfoSRshaXo

#1373 replaced the platform's holon partition with xbrlkit's and
regenerated the SaaS demo's sample; the other four tracked samples
were still the old partition's output, each missing 52–59 element
declarations for the rows its arcs reach. Regenerated offline from
the flat JSON-LD beside each, through the DataBook converter — the
same path the SaaS sample took. Every arc endpoint is now declared
and each file reads back in xbrlkit with the report id as its
accession.

Claude-Session: https://claude.ai/code/session_01VQNt2hdNJqbJwfoSRshaXo
@github-actions github-actions Bot added the change:normal Normal change: automated review documented on the pull request before merge label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Change classification: normal — platform or application code changed.

A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The change-classification job requests that review and passes once it has been posted. Recorded by the change-classification job.

@jfrench9

jfrench9 commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@claude please review this PR

@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown

Claude finished @jfrench9's task in 2m 54s —— View job


Review: chore/holon-samples-regen

Scope confirmed: only the 4 sample files changed (git diff origin/main...HEAD --stat), no code touched.

Verified independently (parsed all 4 files with jq, diffed against origin/main):

sample valid JSON undeclared from/to endpoints concepts (distinct rs:Element) unlabelled concepts fact content unchanged
coffee-roaster-demo 0 101 8 (→ 93 labelled, matches PR table) ✅ identical
roboledger-demo 0 93 0 ✅ identical
seattle-method-case-1 0 93 0 ✅ identical
world-online 0 93 0 ✅ identical
  • The "undeclared endpoints" fix checks out: cross-referencing every rs:Association.from/.to against declared rs:Element nodes yields zero unresolved refs in all four files, vs. the 52–59 gaps described pre-regen.
  • "Facts are unchanged" also checks out: diffing {element, numericValue, decimals, factType} for every rs:Fact (sorted, ignoring internal reference IDs) against the pre-regen files shows byte-identical content in all four samples.
  • The only diff in fact nodes themselves is internal reference plumbing (period/unit/factSet now use content-addressed hash IDs, structure dropped from facts, factSet can be an array) — this matches the shape already present in examples/saas_startup_demo/sample_output/saas-startup-demo.holon.jsonld (regenerated in fix(serialization): emit the holon from xbrlkit through the bundle bridge #1373 and already merged), so it's consistent with the converter's current schema rather than a regression introduced here.
  • Report accessionNumber is present and distinct per sample, consistent with the "loads with the report id as its accession" claim.

No issues found. This is a clean, verifiable data-only regeneration — approving from a correctness standpoint.

@jfrench9

Copy link
Copy Markdown
Member Author

Closing: these were regenerated through the DataBook reader path, not downloaded from the API like every other sample, so their period/unit ids differ from the flat JSON-LD beside them. The samples come back as a full re-download once the bridge passes structure and fact-set ids through to xbrlkit (follow-up in progress).

@jfrench9 jfrench9 closed this Sep 10, 2026
@jfrench9
jfrench9 deleted the chore/holon-samples-regen branch September 11, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:normal Normal change: automated review documented on the pull request before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant