-
Notifications
You must be signed in to change notification settings - Fork 7
Implements #5311 #5354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements #5311 #5354
Conversation
js802025
commented
Oct 18, 2025
- Added Sponsor, SponsorDomain, SponsorUser Resources.
- Added Nova Rule to verify user email is in valid domain names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, confirm with a second opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional notes:
- Consider setting a policy to limit who can interact with these models
- Consider configuring index settings for these models, at a minimum
displayedAttributesshould be set to the primary key to minimize bytes on the wire - Consider adding these models to the
ImportAllModelscommand so they are indexed correctly
|
Which users should we limit access to? |
|
The highest-level role for non-technical users is We typically create a new permission, attach it to the role, and then check the permission in the policy: see #4400 for a rough example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments are also still outstanding from prior review
database/migrations/2025_10_21_113837_add_sponsor_permissions_to_officers.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review and respond to open comments from prior reviews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes from quick UI testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM