Skip to content

Conversation

@js802025
Copy link
Contributor

  • Added Sponsor, SponsorDomain, SponsorUser Resources.
  • Added Nova Rule to verify user email is in valid domain names.

jvogt23
jvogt23 previously approved these changes Oct 19, 2025
Copy link
Collaborator

@jvogt23 jvogt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirm with a second opinion

@jvogt23 jvogt23 requested a review from a team October 19, 2025 17:50
This was linked to issues Oct 19, 2025
Copy link
Member

@kberzinch kberzinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional notes:

  • Consider setting a policy to limit who can interact with these models
  • Consider configuring index settings for these models, at a minimum displayedAttributes should be set to the primary key to minimize bytes on the wire
  • Consider adding these models to the ImportAllModels command so they are indexed correctly

@js802025
Copy link
Contributor Author

Which users should we limit access to?

@kberzinch
Copy link
Member

The highest-level role for non-technical users is officer - https://my.robojackets.org/docs/admins/permissions-roles/

We typically create a new permission, attach it to the role, and then check the permission in the policy: see #4400 for a rough example

@jvogt23 jvogt23 requested a review from a team October 21, 2025 22:39
Copy link
Member

@kberzinch kberzinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments are also still outstanding from prior review

@js802025 js802025 requested a review from kberzinch October 26, 2025 00:24
Copy link
Member

@kberzinch kberzinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and respond to open comments from prior reviews

@js802025 js802025 requested a review from kberzinch October 27, 2025 04:44
Copy link
Member

@kberzinch kberzinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes from quick UI testing

@js802025 js802025 requested a review from kberzinch November 1, 2025 18:31
@kberzinch kberzinch requested a review from jvogt23 November 1, 2025 18:32
Copy link
Collaborator

@jvogt23 jvogt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvogt23 jvogt23 merged commit 94d6213 into main Nov 2, 2025
8 checks passed
@jvogt23 jvogt23 deleted the sponsor-model branch November 2, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sponsor/Recruiter Model - Nova Sponsor/Recruiter Model

4 participants