Disable another action test since there is a rclpy bug

RobotWebTools · Nov 1, 2023 · 5d93ca0 · 5d93ca0
1 parent 03c350f
commit 5d93ca0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/rosbridge_library/src/rosbridge_library/capabilities/advertise_service.py b/rosbridge_library/src/rosbridge_library/capabilities/advertise_service.py
@@ -31,7 +31,7 @@ def next_id(self):
 
     async def handle_request(self, req, res):
         # generate a unique ID
-        request_id = "service_request:" + self.service_name + ":" + str(self.next_id())
+        request_id = f"service_request:{self.service_name }:{self.next_id()}"
 
         future = rclpy.task.Future()
         self.request_futures[request_id] = future

diff --git a/rosbridge_library/test/capabilities/test_action_capabilities.py b/rosbridge_library/test/capabilities/test_action_capabilities.py
@@ -95,6 +95,9 @@ def test_advertise_action(self):
         )
         self.advertise.advertise_action(advertise_msg)
 
+    @unittest.skip(
+        reason="Currently fails in Iron/Rolling due to https://github.com/ros2/rclpy/issues/1195, need to fix this"
+    )
     def test_execute_advertised_action(self):
         # Advertise the action
         action_path = "/fibonacci_action_2"