Default subscriber QOS to BestEffort, account for TRANSIENT_LOCAL#1033
Merged
Conversation
* use permissive QoS to ensure compatibilty with publishers * use RELIABLE qos if publisher found to be TRANSIENT_LOCAL --------- Co-authored-by: William Wedler <wwedler@riseup.net> Co-authored-by: Mike Wake <michael.wake@aosgrp.com.au>
…ishers (#1023) * fix: incompatible QoS settings for subs for reliability, if any subscribed topic has a non-reliable policy, we set reliability to best effort. for durability, if if any subscribed topic has a non-transient-local policy, we set durability to volatile. * fix: define variables * fix: lint and remove default publisher qos durability setting * fix: default durability policy for tests * fix: code fixed according to recommendation * fix: lint * fix: added recommended changes * fix: reverted test changes * fix: check if there are any publisher. * fix: lint * fix: qos settings * fix: requested changes
sea-bass
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #991 and #1023.