Port unit tests to ROS 2 + Fix CBOR conversion and PNG compression #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
changed the title
|
@achim-k This is ready for review. I've run the unit tests numerous times to try see if anything is flaky, and seems to be in good shape. |
sea-bass
force-pushed
the
update-tests-ros2
branch
from
e30e52d to
ca84599
Compare
sea-bass
commented
Oct 13, 2023
rosbridge_library/src/rosbridge_library/capabilities/advertise_service.py
Outdated
Show resolved
Hide resolved
sea-bass
commented
Oct 13, 2023
rosbridge_library/src/rosbridge_library/capabilities/service_response.py
Outdated
Show resolved
Hide resolved
sea-bass
force-pushed
the
update-tests-ros2
branch
from
43c733b to
84f7461
Compare
eholum
reviewed
Oct 13, 2023
sea-bass
commented
Oct 14, 2023
rosbridge_library/test/capabilities/test_service_capabilities.py
Outdated
Show resolved
Hide resolved
EzraBrooks
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to bring all
rosbridge_libraryunit tests up to date with ROS 2 so that CI is actually testing most of the functionality.There is one test that raises an exception when unadvertising a service, and I think it's this issue: ros2/rclpy#1098 -- so just left a TODO for now.
Closes #856