Remove ament_cmake_core and ament_cmake_ros dependencies in message packages
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolling CI has had a warning about `ament_cmake_core` not being included, which... isn't needed.
sea-bass
changed the title
ament_cmake_core dependency in rosbridge_test_msgsament_cmake_core and ament_cmake_ros dependencies in message packages
|
Actually, never mind. This is due to ros-tooling/action-ros-ci#844, so we can just merge through these Rolling failures for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Rolling CI has had a warning about
ament_cmake_coreandament_cmake_rosnot being included in the message definition packages, which... isn't needed.