Drop support for ROS 2 Iron #981
Conversation
|
@MatthijsBurgh or @bjsowa -- can you go into the repo settings and remove the Iron check as required on the |
I don't have admin access to this repo so I'm unable to do this. |
| @@ -25,7 +25,7 @@ | |||
| class TestActionCapabilities(unittest.TestCase): | |||
| def setUp(self): | |||
| rclpy.init() | |||
| self.executor = SingleThreadedExecutor() | |||
| self.executor = MultiThreadedExecutor() | |||
There was a problem hiding this comment.
What's the reasoning behind this change?
There was a problem hiding this comment.
The tests that were previously skipped seem to have needed this. I was getting some flaky behavior without this for some reason.
There was a problem hiding this comment.
I have very bad experiences with the MultiThreadedExecutor, see ros2/rclpy#1223. So we need to make sure we use CycloneDDS to limit the issues. (Or keep using the SingleThreadedExecutor)
There was a problem hiding this comment.
They work fine on my end with single threaded executor
There was a problem hiding this comment.
Alright -- I've put it back into SingleThreaded EDIT: #981 (comment)
That rclpy is issue is very concerning! wow
sea-bass
force-pushed
the
remove-iron
branch
2 times, most recently
from
b70b270 to
a831604
Compare
|
Yeah, see the test was flaky on one of the 4 runs with I can either keep that test disabled, or go to |
That's fine by me |
sea-bass
force-pushed
the
remove-iron
branch
from
a831604 to
e971732
Compare
@MatthijsBurgh Could you please do it? |
|
Done |
Public API Changes
None
Description
This PR removes support for ROS 2 Iron now that it's EOL.
Additionally, this lets us re-enable some unit tests that were previously failing on Iron.