Fix infinite loop in QueueMessageHandler #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
It seems that when a client disconnects the following can happen:
protocol.finish()finishon all capabilitiessubscribecapability callsunregisteron all subscriptionsfinishon all its message handlersQueueMessageHandlertries to push all buffered messages but it never pops the message from the queue so it just pushes the same message in an infinite loop.This PR fixes the QueueMessageHandler finishing by adding the missing queue popping (Thanks @daisukes for this contribution).
This should fix #891