Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status field to action result messages #796

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Sep 29, 2024

Public API Changes
N/A

Description
This goes along with RobotWebTools/rosbridge_suite#953, in which a status field was added to the action_result message.

It also adds a setCanceled() helper function to the Action class to wrap the setting of the right status in cancellation settings.

Copy link
Contributor

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm like half asleep and on a plane right now so maybe I'm missing context, but I'm not sure I grok what's going on here. Is this an action-server-side feature or action-client-side?

@sea-bass
Copy link
Contributor Author

sea-bass commented Oct 1, 2024

I'm like half asleep and on a plane right now so maybe I'm missing context, but I'm not sure I grok what's going on here. Is this an action-server-side feature or action-client-side?

This is a server-side feature.

For context, take a look at RobotWebTools/rosbridge_suite#920 and the PR that tries to solve it (RobotWebTools/rosbridge_suite#953).

Basically, there are 2 new things:

  1. Now the action_result message carries a status with it (hence the additions to the setSucceeded()/setFailed() functions here)
  2. Also, when you cancel a goal client-side, instead of the client automatically aborting the goal, the server is responsible for telling you that it was canceled (hence the addition of the setCanceled() function here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants