Fix AIO.lua error with Eluna multi-state #17
+142
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, looks alright. I will make a few tweaks and it should be good. |
|
I made some changes. Would it be possible for you to test the new code? |
|
Thank you for the follow-up. I'm getting some new errors in all my client-side scripts that trigger both on server startup and while re-loading them. Caused by the usual AIO "code practice": If I were to comment out the check (or replace it with this check): Maybe I do not fully understand what's at play here. My scripts are working fine as usual, however the errors in worldserver console are printed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using recent Eluna (Trinity) with multi-state mode causes errors for AIO.lua executed outside of world state. These errors happen on worldserver startup and whenever re-loading Eluna scripts.
This fix works, but I'm unsure if it's the best approach.