fix: passcode update issues on iOS #6547

paviad · 2025-08-11T18:37:54Z

Proposed changes

For some reason, the code works fine on Android but doesn't work on iOS. I tracked it down to a weird timing issue and added a delay in the appropriate place.

Issue(s)

Resolves #6313

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

This fix feels more like a workaround than a proper fix, however creating a proper fix for this is not something that I would be able to achieve in reasonable time.

Summary by CodeRabbit

Bug Fixes
- Improved rendering stability for passcode entry and selection components.
- Enhanced iOS compatibility when changing passcode settings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-07T17:00:07Z

Walkthrough

Fixes an iPhone app hang when changing passcode by reusing a ref in PasscodeChoose, adding React keys to prevent re-rendering issues in passcode components, and introducing a 1-second delay workaround in ScreenLockConfigView before modal presentation.

Changes

Cohort / File(s)	Change Summary
Passcode component key stabilization `app/containers/Passcode/Base/Dots.tsx`, `app/containers/Passcode/PasscodeChoose.tsx`, `app/containers/Passcode/PasscodeEnter.tsx`	Added React key props to Base and View components to ensure stable element identity during state transitions and avoid rendering warnings from list items. PasscodeChoose now reuses chooseRef for both CHOOSE and CONFIRM states instead of using a separate confirmRef.
iOS modal race condition workaround `app/views/ScreenLockConfigView.tsx`	Added 1-second artificial delay in changePasscode after local authentication to prevent back-to-back modal presentations from causing app hang on iOS.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Verify that key values ("passcode-choose", "passcode-enter") are appropriate and won't cause unintended re-mounts
Understand the necessity and timing of the 1-second iOS delay and confirm it doesn't introduce perceptible UX lag
Confirm that reusing chooseRef for both CHOOSE and CONFIRM states in PasscodeChoose doesn't cause ref conflicts or state management issues

Possibly related PRs

fix: input in confirm passcode not getting reset #6687: Modifies PasscodeChoose.tsx's ref handling for choose/confirm states; coordinates with this PR's chooseRef reuse logic.

Suggested reviewers

diegolmello

Poem

🐰 With keys in hand and refs now wise,
Two modals cease to synchronize,
A heartbeat's pause, an iOS mend,
Where passcodes now flow to the end. ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: passcode update issues on iOS' directly and concisely describes the main change—addressing a passcode-related bug on iOS platform.
Linked Issues check	✅ Passed	The PR successfully addresses issue #6313 by fixing the app hang when changing passcode on iPhone through strategic key props and timing adjustments.
Out of Scope Changes check	✅ Passed	All changes (key props in Passcode components and iOS delay workaround) are directly scoped to fixing the passcode update issue on iOS, with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd62a2 and 576a648.

📒 Files selected for processing (4)

app/containers/Passcode/Base/Dots.tsx (1 hunks)
app/containers/Passcode/PasscodeChoose.tsx (2 hunks)
app/containers/Passcode/PasscodeEnter.tsx (1 hunks)
app/views/ScreenLockConfigView.tsx (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

app/views/ScreenLockConfigView.tsx (1)

app/lib/encryption/helpers/deferred.ts (1)

resolve (32-34)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: ESLint and Test / run-eslint-and-test

🔇 Additional comments (3)

app/containers/Passcode/PasscodeEnter.tsx (1)

82-91: Static key on Base is harmless and consistent with other passcode screens

Adding key={"passcode-enter"} here doesn’t change behavior (static key on a single element), but it’s fine for consistency with the other passcode components.

app/containers/Passcode/Base/Dots.tsx (1)

21-47: Good addition of key on list items

key={val} on the outer View is appropriate here and will eliminate React’s key warnings without side effects for this static-range list.

app/containers/Passcode/PasscodeChoose.tsx (1)

40-62: Ref unification and key usage in PasscodeChoose look good

Reusing chooseRef for both CHOOSE and CONFIRM states simplifies the component and keeps all imperative calls (clearPasscode, animate) going through a single ref, which should make the flow more predictable. The added key={"passcode-choose"} on both branches is effectively neutral here (same type, same key, never rendered as siblings) but harmless and keeps things aligned with PasscodeEnter.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Rohit3523 · 2025-12-07T17:01:16Z

app/containers/Passcode/PasscodeEnter.tsx


 	return (
 		<Base
+		  key={"passcode-enter"}


can you remove this because it is not required

Rohit3523 · 2025-12-07T17:01:23Z

app/containers/Passcode/PasscodeChoose.tsx


 	return (
 		<Base
+			key={"passcode-choose"}


can you remove this because it is not required

Rohit3523 · 2025-12-07T17:02:20Z

app/containers/Passcode/Base/Dots.tsx

 				const marginLeft = lengthSup ? 10 - (SIZE_FULL - SIZE_EMPTY) / 2 : 10;
 				return (
-					<View style={styles.dotsView}>
+					<View key={val} style={styles.dotsView}>


can you remove this because it is not required

Rohit3523 · 2025-12-07T17:02:28Z

app/views/ScreenLockConfigView.tsx

 		if (autoLock) {
 			await handleLocalAuthentication(true);
 		}
+		console.log('IOS workaround - waiting 1 sec...');


Remove this one

Rohit3523 · 2025-12-07T17:02:34Z

app/views/ScreenLockConfigView.tsx

 		}
+		console.log('IOS workaround - waiting 1 sec...');
+		await new Promise(resolve => setTimeout(resolve, 1000));
+		console.log('IOS workaround - waiting 1 sec...done');


Remove this one

Rohit3523 · 2025-12-07T17:03:24Z

Hey @paviad, can you please make the changes

paviad added 2 commits August 11, 2025 21:33

fix: weird timing issues in ios

2984567

fix: rn missing key warnings

08bf716

paviad mentioned this pull request Aug 11, 2025

bug: App Stops working when change passcode on iPhone #6313

Open

paviad had a problem deploying to experimental_android_build August 11, 2025 18:40 — with GitHub Actions Error

paviad had a problem deploying to official_android_build August 11, 2025 18:40 — with GitHub Actions Error

paviad had a problem deploying to experimental_ios_build August 11, 2025 18:40 — with GitHub Actions Error

paviad had a problem deploying to official_ios_build August 11, 2025 18:40 — with GitHub Actions Error

Merge branch 'develop' into pr2

9d87fbb

paviad had a problem deploying to experimental_ios_build August 13, 2025 07:05 — with GitHub Actions Error

paviad had a problem deploying to experimental_android_build August 13, 2025 07:05 — with GitHub Actions Error

paviad had a problem deploying to official_android_build August 13, 2025 07:05 — with GitHub Actions Error

paviad had a problem deploying to official_ios_build August 13, 2025 07:05 — with GitHub Actions Error

Merge branch 'develop' into pr2

116ddd1

paviad had a problem deploying to approve_e2e_testing August 14, 2025 21:16 — with GitHub Actions Failure

paviad had a problem deploying to official_ios_build August 14, 2025 21:19 — with GitHub Actions Failure

paviad had a problem deploying to experimental_ios_build August 14, 2025 21:19 — with GitHub Actions Failure

paviad had a problem deploying to official_android_build August 14, 2025 21:19 — with GitHub Actions Failure

paviad had a problem deploying to experimental_android_build August 14, 2025 21:19 — with GitHub Actions Failure

Merge branch 'develop' into pr2

576a648

Rohit3523 requested a deployment to approve_e2e_testing December 7, 2025 17:00 — with GitHub Actions Waiting

Rohit3523 reviewed Dec 7, 2025

View reviewed changes

Rohit3523 requested a deployment to experimental_android_build December 7, 2025 17:03 — with GitHub Actions Waiting

Rohit3523 requested a deployment to experimental_ios_build December 7, 2025 17:03 — with GitHub Actions Waiting

Rohit3523 requested a deployment to official_android_build December 7, 2025 17:03 — with GitHub Actions Waiting

Rohit3523 requested a deployment to official_ios_build December 7, 2025 17:03 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: passcode update issues on iOS #6547

fix: passcode update issues on iOS #6547

Uh oh!

paviad commented Aug 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 7, 2025 •

edited

Loading

Uh oh!

Rohit3523 Dec 7, 2025

Uh oh!

Rohit3523 Dec 7, 2025

Uh oh!

Rohit3523 Dec 7, 2025

Uh oh!

Rohit3523 Dec 7, 2025

Uh oh!

Rohit3523 Dec 7, 2025

Uh oh!

Rohit3523 commented Dec 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: passcode update issues on iOS #6547

Are you sure you want to change the base?

fix: passcode update issues on iOS #6547

Uh oh!

Conversation

paviad commented Aug 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

Types of changes

Checklist

Further comments

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Rohit3523 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Rohit3523 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Rohit3523 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Rohit3523 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Rohit3523 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Rohit3523 commented Dec 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paviad commented Aug 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 7, 2025 •

edited

Loading